Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NBC #5431

Merged
merged 5 commits into from Jul 23, 2023
Merged

Add NBC #5431

merged 5 commits into from Jul 23, 2023

Conversation

PeterShaggyNoble
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble commented Apr 9, 2021

NBC

Issue: Closes #5239
Similarweb rank: 9,642

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icon from SVG in source header. Struggled to pick a colour for this one as the 6 colours used in the full colour logo all represent sub-brands or operations (news, sports, entertainment, stations, network & production, respectively). In the end, I went with the grey from their website's header but I'm far from convinced that it's the correct choice.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label Apr 9, 2021
@jorgeamadosoria
Copy link
Contributor

NBC Sports guidelines: https://media.ussa.org/media-center/USSA%20Partners/NBC%20Sports%20Network/NBCSPORTS_LOGO_GUIDELINES.pdf

It's not the same as NBC, but it's close enough. It has black and "cool grey" brand colors, so I think grey is ok.

Also, this page: https://www.cghnyc.com/work/project/nbc seems to suggest there is no precedence in the feather colors, and provides a few monochrome "early sketches" that may serve as inspiration.

All in all, I would add the guideline linked above and keep the cool grey as brand color.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of closing this one out, I'm going to approve it (with a minor tweak to the JSON, which I'll commit in a moment). Though a brand guidelines document was found, that was for a part of the NBC group, not the company as a whole. Should we find a better source/guidelines link in the future, we can include it for sure.

_data/simple-icons.json Outdated Show resolved Hide resolved
@adamrusted adamrusted merged commit 115e660 into simple-icons:develop Jul 23, 2023
3 checks passed
mondeja added a commit that referenced this pull request Jul 30, 2023
# New Icons

- Adroll (#9040)
- Airbrake.io (#8976)
- Alteryx (#9008)
- Amazon Identity Access Management (#8739)
- Apifox (#9123)
- BentoML (#9056)
- BisectHosting (#9027)
- Bombardier (#9029)
- Brevo (#9075)
- bspwm (#9025)
- Chatwoot (#7005)
- Creality (#9130)
- EasyEDA (#9135)
- F# (#9011)
- Google Docs (#8981)
- Google Forms (#9080)
- HashiCorp (#9037)
- Intuit (#9032)
- IRIS (#5796)
- Jovian (#8989)
- Miraheze (#9054)
- NBC (#5431)
- NgRx (#9082)
- Open Source Hardware (#9125)
- Opera GX (#8750)
- Palo Alto Networks (#9038)
- Paychex (#8998)
- Pearson (#9030)
- Phoenix Framework (#9007)
- Podcast Index (#9100)
- PythonAnywhere (#9033)
- Qlik (#8964)
- Radix UI (#9079)
- remark (#9022)
- Sage (#9031)
- Semrush (#9036)
- SST (#9063)
- Stryker (#7388)
- SVG.js (#9083)
- Thangs (#9023)
- Thurgauer Kantonalbank (#9012)
- Tina (#9097)
- Voron Design (#8961)
- Zod (#9078)

# Updated Icons

- Arduino (#9145)
- Bose (#9144)
- Zendesk (#9124)
- Zenn (#9124)
- Zerply (#9124)
- Zettlr (#9124)
- Zig (#9124)
- Zigbee (#9124)
- Zilch (#9124)
- ZincSearch (#9124)
- Zingat (#9124)
- Zorin (#9124)
@PeterShaggyNoble PeterShaggyNoble deleted the add/nbc branch November 17, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: NBC
3 participants