Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remark icon #9022

Merged
merged 7 commits into from Jul 29, 2023
Merged

Add remark icon #9022

merged 7 commits into from Jul 29, 2023

Conversation

developomp
Copy link
Contributor

preview

Issue: closes #8933

GitHub: https://github.com/remarkjs/remark - 6.5k stars

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jul 15, 2023
adamrusted
adamrusted requested changes Jul 23, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm spotting some difference between your PR in black, and the source icon in red. Could you give this one another go please @developomp 🙏

@developomp
Copy link
Contributor Author

I'm spotting some difference between your PR in black, and the source icon in red. Could you give this one another go please @developomp pray

@adamrusted fixed!

adamrusted
adamrusted requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing some differences when comparing PR in black to the source file in red. Might need either 4 decimals of precision in SVGO, or a re-work of the icon.

@developomp
Copy link
Contributor Author

Well this is annoying. How can I check for differences myself?

@adamrusted
Copy link
Member

So I keep two copies of the source icon while I'm working on them - one I label as remark.src.svg for example, and the one I'm working on to just remark.svg. I then do all the optimisation so that the latter passes the linters, and then pull in the path from the .src.svg file to compare.

@developomp
Copy link
Contributor Author

Found the problem. Resizing svgs in figma does that. I'll try to do it in inkscape.

@developomp
Copy link
Contributor Author

@adamrusted Sorry for all the trouble. I believe it is fixed now.

@adamrusted adamrusted self-assigned this Jul 26, 2023
adamrusted
adamrusted approved these changes Jul 29, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @developomp 🎉

@adamrusted adamrusted merged commit 507001d into simple-icons:develop Jul 29, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Jul 30, 2023
Merged
mondeja added a commit that referenced this pull request Jul 30, 2023
@mondeja
Release 44 new icons and 12 updated icons (v9.8.0)
64a2035 
# New Icons

- Adroll (#9040)
- Airbrake.io (#8976)
- Alteryx (#9008)
- Amazon Identity Access Management (#8739)
- Apifox (#9123)
- BentoML (#9056)
- BisectHosting (#9027)
- Bombardier (#9029)
- Brevo (#9075)
- bspwm (#9025)
- Chatwoot (#7005)
- Creality (#9130)
- EasyEDA (#9135)
- F# (#9011)
- Google Docs (#8981)
- Google Forms (#9080)
- HashiCorp (#9037)
- Intuit (#9032)
- IRIS (#5796)
- Jovian (#8989)
- Miraheze (#9054)
- NBC (#5431)
- NgRx (#9082)
- Open Source Hardware (#9125)
- Opera GX (#8750)
- Palo Alto Networks (#9038)
- Paychex (#8998)
- Pearson (#9030)
- Phoenix Framework (#9007)
- Podcast Index (#9100)
- PythonAnywhere (#9033)
- Qlik (#8964)
- Radix UI (#9079)
- remark (#9022)
- Sage (#9031)
- Semrush (#9036)
- SST (#9063)
- Stryker (#7388)
- SVG.js (#9083)
- Thangs (#9023)
- Thurgauer Kantonalbank (#9012)
- Tina (#9097)
- Voron Design (#8961)
- Zod (#9078)

# Updated Icons

- Arduino (#9145)
- Bose (#9144)
- Zendesk (#9124)
- Zenn (#9124)
- Zerply (#9124)
- Zettlr (#9124)
- Zig (#9124)
- Zigbee (#9124)
- Zilch (#9124)
- ZincSearch (#9124)
- Zingat (#9124)
- Zorin (#9124)
@adamrusted adamrusted removed their assignment Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Remark Icon
2 participants
@developomp @adamrusted