Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spring boot #5687

Merged
merged 9 commits into from May 17, 2021
Merged

Add spring boot #5687

merged 9 commits into from May 17, 2021

Conversation

echoaman
Copy link
Contributor

@echoaman echoaman commented May 13, 2021

Spring Boot

Issue: Closes #5683
Alexa rank: n/a (subdirectory of parent brand's site)
GitHub stars ~55.1k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label May 13, 2021
@adamrusted adamrusted linked an issue May 14, 2021 that may be closed by this pull request
@echoaman
Copy link
Contributor Author

Check now

@adamrusted
Copy link
Member

Thanks for the contribution @echoaman, and welcome to Simple Icons!
Looks like the size of your SVG was impacted by the optimization process, resulting in your path being 23.995px wide instead of 24px wide, which the linter requires. Would you mind taking another look at editing this, making sure to keep the aspect ratio the same, just adjusting the width to suit?

@echoaman
Copy link
Contributor Author

@adamrusted I will retry. Sorry for the troubles.

@adamrusted
Copy link
Member

No problem! I've assigned myself to review this PR, so whenever you've made changes I'll take a quick look. If you're having difficulty with editing it, let me know here.

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @echoaman - though it looks like you also stretched the height to fit 24px, which means the icon's aspect ratio has now been impacted (see yours overlaid in black over the original, in green here). Could you take another look at this, maintaining the correct aspect ratio so only the longest side is 24px?

@echoaman echoaman requested a review from adamrusted May 14, 2021 19:34
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's looking a lot closer to the source icon, thank you @echoaman!
There is still a little stretching to the PR icon when compared to the source in green, though that may be down to the optimizer. It may work better if you optimize the source file to 4 decimals instead of 3, which is just a slider on SVGOMG - or a quick edit to svgo.config.js and running npm run svgo -- icons/springboot.svg to fix. Let me know if you need some more help with this one - I think we're nearly there though 💪

@echoaman echoaman requested a review from adamrusted May 16, 2021 14:19
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for you continued work on this @echoaman! I'll merge this now, and it'll be in our release next Sunday! 🚀

@adamrusted adamrusted merged commit ea6bbac into simple-icons:develop May 17, 2021
ericcornelissen added a commit that referenced this pull request May 23, 2021
# New Icons

- Betfair (#5727)
- Chai (#5222)
- FMOD (#5720)
- ImageJ (#5494)
- Intigriti (#5733)
- MicroPython (#5681)
- Perforce (#5724)
- Spring Boot (#5687)
- tqdm (#5699)
- Weblate (#5688)
- Wwise (#5722)

# Updated Icons

- Azure Pipelines (#5248)
- Coinbase (#5712)
- FreeBSD (#5701)
- G2A (#5703)
- GeeksforGeeks (#5704)
- Geocaching (#5702)
- Ghost (#5739)
- Habr (#5713)
- Hackster (#5735)
- Helly Hansen (#5737)
- IBM (#5740)
- IMDb (#5700)
- Infosys (#5742)
- Nubank (#5734)
- PostgreSQL (#5715)
- Power BI (#5716)
- Viadeo (#5260)
@adamrusted adamrusted removed their assignment Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Spring boot icon
2 participants