New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spring boot #5687
Add spring boot #5687
Conversation
Check now |
Thanks for the contribution @echoaman, and welcome to Simple Icons! |
@adamrusted I will retry. Sorry for the troubles. |
No problem! I've assigned myself to review this PR, so whenever you've made changes I'll take a quick look. If you're having difficulty with editing it, let me know here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @echoaman - though it looks like you also stretched the height to fit 24px, which means the icon's aspect ratio has now been impacted (see yours overlaid in black over the original, in green here). Could you take another look at this, maintaining the correct aspect ratio so only the longest side is 24px?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's looking a lot closer to the source icon, thank you @echoaman!
There is still a little stretching to the PR icon when compared to the source in green, though that may be down to the optimizer. It may work better if you optimize the source file to 4 decimals instead of 3, which is just a slider on SVGOMG - or a quick edit to svgo.config.js
and running npm run svgo -- icons/springboot.svg
to fix. Let me know if you need some more help with this one - I think we're nearly there though 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thanks for you continued work on this @echoaman! I'll merge this now, and it'll be in our release next Sunday! 🚀
# New Icons - Betfair (#5727) - Chai (#5222) - FMOD (#5720) - ImageJ (#5494) - Intigriti (#5733) - MicroPython (#5681) - Perforce (#5724) - Spring Boot (#5687) - tqdm (#5699) - Weblate (#5688) - Wwise (#5722) # Updated Icons - Azure Pipelines (#5248) - Coinbase (#5712) - FreeBSD (#5701) - G2A (#5703) - GeeksforGeeks (#5704) - Geocaching (#5702) - Ghost (#5739) - Habr (#5713) - Hackster (#5735) - Helly Hansen (#5737) - IBM (#5740) - IMDb (#5700) - Infosys (#5742) - Nubank (#5734) - PostgreSQL (#5715) - Power BI (#5716) - Viadeo (#5260)
Issue: Closes #5683
Alexa rank: n/a (subdirectory of parent brand's site)
GitHub stars ~55.1k
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24