Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Chai #5222

Merged
merged 6 commits into from May 17, 2021
Merged

Added Chai #5222

merged 6 commits into from May 17, 2021

Conversation

adamrusted
Copy link
Member

chai

Issue: Fixes #4983
Alexa rank: 164,653

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Inverted icon to preserve clarity as much as possible. Alternative treatment below is truer to the darker segments of the original, though lacks clarity at smaller sizes.

Alternative Treatment

chai (1)

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 11, 2021
@PeterShaggyNoble
Copy link
Member

I think the alternative treatment is the way to go here.

@adamrusted
Copy link
Member Author

Done! Reduced the points down in the C wherever possible, so there may be a couple hairline differences.

@PeterShaggyNoble
Copy link
Member

Looking good, @adamrusted 👍🏻 Just a couple of tiny differences (1 & 2, with yours in red) and at the very bottom. But if @keithamus is OK with them, we can run with them.

Keith, as well, is there any licensing info or usage guidelines you'd like us to include with your icon?

@keithamus
Copy link

The yellow on grey for the light buttons doesn't seem like a satisfactory contrast ratio, perhaps they should be altered? The typeface is Apache 2 Licensed, the logos are MIT licensed, so minimal licensing restrictions (just a case of including notices).

@PeterShaggyNoble
Copy link
Member

Thanks for the feedback, @keithamus 🙂

Those buttons are examples of how the various Shields.io styles will look, as they use our package. We could use the red, instead, if you prefer but that would also then be the colour we'd be serving up to all our users.

@keithamus
Copy link

Is it possible to specify two colours? One against light backgrounds and one against dark?

@adamrusted
Copy link
Member Author

Is it possible to specify two colours? One against light backgrounds and one against dark?

Not with the project in it's current format, no. The hex we provide only serves as a 'guide' to end-users anyway, as the SVG is served without colour (defaulting to the path being black), with the hex being available via the JSON. In most cases, there's a clear "primary colour" for the brand, that something like shields.io will pull for their badges - though I get the worry about the cream on white being rubbish for readability.

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Apr 9, 2021
@adamrusted
Copy link
Member Author

Hey @keithamus - given we're only able to specify the one colour, would the red hex be preferred? We can look at getting this merged in if that's the case!

@keithamus
Copy link

Sure. Let's use the red.

@adamrusted
Copy link
Member Author

Amazing, thank you! I'll put this back up for review, and hopefully we'll see it added soon!

@adamrusted adamrusted removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label May 3, 2021
@PeterShaggyNoble
Copy link
Member

I'm seeing a few very minor differences in the "C", @adamrusted, such as this one in the top right of the inner curve. Could you take another quick look to see if you can fix them up?

Of course, if @keithamus is OK with such minor differences then this can be merged straight in instead.

@adamrusted
Copy link
Member Author

Could you take another quick look to see if you can fix them up?

Converted the path without removing any points, and it's passing the linter and matching up.

Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now, @adamrusted, nice work 👍🏻

Thanks for your feedback & contributions on this one, @keithamus, much appreciated 🙂

@PeterShaggyNoble PeterShaggyNoble merged commit 9bc4d32 into simple-icons:develop May 17, 2021
@adamrusted adamrusted deleted the Add/ChaiJS branch May 17, 2021 11:31
ericcornelissen added a commit that referenced this pull request May 23, 2021
# New Icons

- Betfair (#5727)
- Chai (#5222)
- FMOD (#5720)
- ImageJ (#5494)
- Intigriti (#5733)
- MicroPython (#5681)
- Perforce (#5724)
- Spring Boot (#5687)
- tqdm (#5699)
- Weblate (#5688)
- Wwise (#5722)

# Updated Icons

- Azure Pipelines (#5248)
- Coinbase (#5712)
- FreeBSD (#5701)
- G2A (#5703)
- GeeksforGeeks (#5704)
- Geocaching (#5702)
- Ghost (#5739)
- Habr (#5713)
- Hackster (#5735)
- Helly Hansen (#5737)
- IBM (#5740)
- IMDb (#5700)
- Infosys (#5742)
- Nubank (#5734)
- PostgreSQL (#5715)
- Power BI (#5716)
- Viadeo (#5260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chaijs Icon
3 participants