Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add StopStalk #5731

Merged
merged 6 commits into from Aug 13, 2021
Merged

Add StopStalk #5731

merged 6 commits into from Aug 13, 2021

Conversation

PeterShaggyNoble
Copy link
Member

StopStalk

Issue: Closes #5329
Alexa rank: ~175k

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Had to redraw the circle 'cause, as usual, Inkscape didn't want to play nice when converting the stroke to a path. Colour from website header.

@PeterShaggyNoble PeterShaggyNoble added the new icon Issues or pull requests for adding a new icon label May 18, 2021
service-paradis
service-paradis reviewed Jul 19, 2021
View reviewed changes
icons/stopstalk.svg
@@ -0,0 +1 @@
<svg role="img" viewBox="0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>StopStalk</title><path d="M12 0A12 12 0 000 12a12 12 0 0012 12 12 12 0 0012-12A12 12 0 0012 0zm-.049 2.953a9.046 9.046 0 01.049 0 9.046 9.046 0 013.46.688L13.57 6.42l2.72.047 1.14-1.703A9.046 9.046 0 0121.047 12 9.046 9.046 0 0112 21.047a9.046 9.046 0 01-2.916-.483l1.937-2.828-2.72-.047-1.258 1.88A9.046 9.046 0 012.953 12a9.046 9.046 0 018.998-9.047zm1.713 4.072a.55.55 0 00-.42.172c-.17.156-.266.248-.297.264-.653-.28-1.196-.42-1.662-.42-.653 0-1.213.219-1.664.639-.45.435-.684.994-.684 1.724 0 .638.204 1.26.577 1.866.388.606 1.024 1.429 1.957 2.455.373.42.7.808.965 1.166.264.342.404.638.404.902 0 .14-.063.264-.188.357a.756.756 0 01-.466.14c-.513 0-1.025-.483-1.538-1.462-.14-.28-.248-.45-.326-.527-.077-.078-.328-.11-.732-.11-.311 0-.465.063-.465.172 0 .016.03.156.092.42l.435 2.004c.016.14.048.217.11.248.046.031.14.047.279.047.358 0 .59-.077.684-.232.046-.078.11-.125.187-.125a.88.88 0 01.358.109 3.19 3.19 0 001.212.248c.653 0 1.243-.217 1.772-.621.528-.42.809-1.01.809-1.787 0-.669-.156-1.259-.467-1.787-.311-.529-.965-1.384-1.975-2.58-.87-1.026-1.305-1.711-1.305-2.069 0-.28.14-.42.436-.42.404 0 .87.405 1.383 1.213.248.389.42.606.498.653.093.062.279.078.574.078.264 0 .42 0 .482-.032.063-.03.094-.076.094-.154 0-.015-.016-.079-.031-.187l-.467-2.051c-.03-.14-.078-.22-.14-.266a9.706 9.706 0 00-.48-.047Z"/></svg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @PeterShaggyNoble 💯
The icon is looking really good! I'm seeing a single extra point that could probably be removed, but I think we can live with it if it messes up too much with the shape:
image

I'm also wondering if we should add MIT for th license as seen at https://github.com/stopstalk/media-resources. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both these comments - I created a separate comment for the license suggestion 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to remove either of those points resulted in the curve becoming distorted for me, @service-paradis - were you able to remove it without issue?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried a few things and it went wrong every time. I think we can live with an extra point for now. We can always revisit it later if we really want to improve.

I will let you merge it if you're ok with that!

@service-paradis service-paradis added the in discussion There is an ongoing discussion that should be finished before we can continue label Jul 19, 2021
@ericcornelissen ericcornelissen added changes requested and removed in discussion There is an ongoing discussion that should be finished before we can continue labels Jul 23, 2021
@PeterShaggyNoble PeterShaggyNoble merged commit 301490d into simple-icons:develop Aug 13, 2021
@PeterShaggyNoble PeterShaggyNoble deleted the add/stopstalk branch August 13, 2021 14:47
@github-actions github-actions bot mentioned this pull request Aug 15, 2021
Merged
ericcornelissen added a commit that referenced this pull request Aug 15, 2021
@ericcornelissen
Release 10 new icons (v5.10.0)
b057b4c 
# New Icons

- DevExpress (#6193)
- Lidl (#6123)
- MLB (#5928)
- New Balance (#5922)
- Rimac Automobili (#6200)
- Shadow (#5843)
- Spring (#5794)
- StopStalk (#5731)
- Target (#5927)
- Under Armour (#5923)
jorgeamadosoria pushed a commit that referenced this pull request Aug 24, 2021
@PeterShaggyNoble
Add StopStalk (#5731)
4abe3e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericcornelissen ericcornelissen ericcornelissen left review comments

@service-paradis service-paradis service-paradis left review comments

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StopStalk
3 participants
@PeterShaggyNoble @ericcornelissen @service-paradis