Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Under Armour #5923

Merged
merged 3 commits into from Aug 11, 2021
Merged

Add Under Armour #5923

merged 3 commits into from Aug 11, 2021

Conversation

huuphongnguyen
Copy link
Contributor

underarmour

Issue:
Alexa rank: 5,722

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jun 11, 2021
@PeterShaggyNoble
Copy link
Member

Thanks for the contribution, @huuphongnguyen 👍🏻

SVG looks good but you should be able to get the precision down to 3 on this one too.

Also, for the colour, I think #1D1D1D would be the correct choice here. What do you think?

@huuphongnguyen
Copy link
Contributor Author

1D1D1D

I think #1D1D1D is perfect.

service-paradis
service-paradis approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@service-paradis service-paradis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 💯 Thank you @huuphongnguyen!

@service-paradis service-paradis merged commit d83b2df into simple-icons:develop Aug 11, 2021
@github-actions github-actions bot mentioned this pull request Aug 15, 2021
Merged
ericcornelissen added a commit that referenced this pull request Aug 15, 2021
@ericcornelissen
Release 10 new icons (v5.10.0)
b057b4c 
# New Icons

- DevExpress (#6193)
- Lidl (#6123)
- MLB (#5928)
- New Balance (#5922)
- Rimac Automobili (#6200)
- Shadow (#5843)
- Spring (#5794)
- StopStalk (#5731)
- Target (#5927)
- Under Armour (#5923)
jorgeamadosoria pushed a commit that referenced this pull request Aug 24, 2021
@huuphongnguyen
Add Under Armour (#5923)
d20436d 
* Add Under Armour

* Update Under Armour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@service-paradis service-paradis service-paradis approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huuphongnguyen @PeterShaggyNoble @service-paradis