Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Grab #6086

Merged
merged 6 commits into from Jul 18, 2021
Merged

Add Grab #6086

merged 6 commits into from Jul 18, 2021

Conversation

LitoMore
Copy link
Member

@LitoMore LitoMore commented Jul 5, 2021

Issue: #6085
Alexa rank: 10,985

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Source from https://en.wikipedia.org/wiki/File:Grab_(application)_logo.svg
#00B14F

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jul 5, 2021
@service-paradis service-paradis linked an issue Jul 10, 2021 that may be closed by this pull request
Copy link
Contributor

@ericcornelissen ericcornelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG looks spot on compared to the source. Just to be clear (e.g. in case this is questioned in the future), where did you source the hex value from? Other than that, just one request for a change and this is good to merge, nice work @LitoMore 👍

_data/simple-icons.json Outdated Show resolved Hide resolved
Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
@LitoMore
Copy link
Member Author

@ericcornelissen OK. Let me check the hex value with my former colleague at Grab.

@ericcornelissen ericcornelissen added awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed and removed changes requested labels Jul 18, 2021
@LitoMore
Copy link
Member Author

@ericcornelissen Color updated.

@ericcornelissen
Copy link
Contributor

@LitoMore, do you have any indication of where we might find this color publicly? If not, I'll leave this for another @simple-icons/maintainers to got their OK and merge it in 🙂

@LitoMore
Copy link
Member Author

LitoMore commented Jul 18, 2021

@ericcornelissen We could find their brand color #00B14F everywhere in the page.

For example the background of Download App button:

@ericcornelissen ericcornelissen removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Jul 18, 2021
@ericcornelissen ericcornelissen merged commit c5f406e into simple-icons:develop Jul 18, 2021
@LitoMore LitoMore deleted the grab branch July 18, 2021 20:43
@ericcornelissen
Copy link
Contributor

Thank you very much for your contribution @LitoMore 🎊

dirien pushed a commit to dirien/simple-icons that referenced this pull request Jul 20, 2021
* Add Grab

* Update SVG

* Update source URL

Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
ericcornelissen added a commit that referenced this pull request Jul 25, 2021
# New Icons

- DPD (#5831)
- Dungeons &amp; Dragons (#5837)
- Grab (#6086)
- Istio (#6093)
- Packer (#5649)
- Windi CSS (#6103)

# Updated Icons

- arXiv (#5884)
- Douban (#6114)
- Douban Read (#6114)
- S7 Airlines (#6147)
- Salesforce (#6147)
- Samsung (#6147)
- Samsung Pay (#6147)
- Sass (#6147)
- Scaleway (#6147)
- Scania (#6147)
- Scribd (#6147)
- Sencha (#6147)
- SEPA (#6147)
- Shazam (#6147)
- Shopify (#6147)
- Shutterstock (#6147)
- Sketch (#6147)
- Slack (#6147)
- SmartThings (#6147)
- Snapchat (#6147)
- Snapcraft (#6147)
- Snowflake (#6147)
- Solidity (#6147)
- SonarLint (#6147)
- SonarQube (#6147)
- SonarSource (#6147)
- Songkick (#6147)
- Songoda (#6147)
- Sourcegraph (#6147)
- Spacemacs (#6147)
- SparkPost (#6147)
- Spotify (#6147)
- Spreaker (#6147)
- Squarespace (#6147)
- Stackbit (#6147)
- StackPath (#6147)
- Starling Bank (#6147)
- STARZ (#6147)
- Statamic (#6147)
- Steam (#6147)
- Steinberg (#6147)
- Stellar (#6147)
- Streamlit (#6147)
- Stylus (#6147)
- Sublime Text (#6147)
- Sumo Logic (#6147)
- SurveyMonkey (#6147)
- SUSE (#6147)
- SVG (#6147)
- Symfony (#6147)
- Synology (#6147)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Grab
2 participants