New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add walmart icon #6269
add walmart icon #6269
Conversation
Not exactly sure how to fix this because when I remove the collinear segment
|
that's fixable on inkscape, I've run into that a couple times. |
I also get the icon scrambled |
ok, we are on the same page then |
Updated icon according to #6272 (comment) @jorgeamadosoria The problem was the attributes on the XML document (like |
oh. I had just solved it by moving around the letters: But great! let's go! :) |
@sachinraja Reading #6272 , I think the hex @service-paradis suggested is not correct. The Spark brand guidelines seem to point strongly towards the yellow rather than the dark blue. I would recommend a second reading there to see what you think? |
Yeah, the spark is definitely yellow. I'll wait for a confirmation though |
As seen in our guidelines, the color should be the brand color, it doesn't have to be in the logo itself. |
For the icon itself, I'm not so sure anymore if we should use the spark or the full wordmark 😅 The following sentence from their guidelines makes me rethink this one. We might get the help of other @simple-icons/maintainers on this one! Sorry @sachinraja!
|
Yeah, this really looks like we should include the wordmark, too.
|
@service-paradis I think this is a bit of a gray area because those aren't actually their brand guidelines, but an internal Walmart resource. |
yellow is a brand color,though. It's one of five in the palette. And specifically it's the one recommended in their own page for use when using the spark. |
If that' the case, then I've provided a SVG text for @sachinraja to validate if they choose to (it deals with the collinear problem they were having) and in that case then the hex is applicable, I think. (I still like the spark better, tho.) |
The hex we provide only serves as a 'guide' to end-users anyway, as the SVG is served without color (defaulting to the path being black), with the hex being available via the JSON. We aim to provide the primary brand color, whatever it fits the icon or not. In this case, yellow is not Walmart primary color whatever icon we choose. Like you mention, we can wait for another @simple-icons/maintainers to weight in about the logo and the color. |
I must agree that I would have expected yellow as the brand color for Walmart, but the color palette shared by @sachinraja in the Pull Request description does strongly suggest that blue is the "correct" choice. To add to that, the spark in the bottom right of that file is in many different colors, further suggesting it doesn't have to be yellow. Also considering that the brand color |
I remain unconvinced. The yellow is called Spark Yellow. It's kind of it's only reason of being there. You would notice the use of the blue ink as a background color for Sections (to bring up the white), of Walmart blue for headers (as expected) and of the little yellow spark in each and every page. Having said that, I have zero power of decision on this. As @service-paradis said, the hex is a suggestion, I can always use any other color when using the library, so it's not a deal breaker. I think I've have exhausted my arguments. I'll accept whatever the ultimately result turns out to be. |
@ericcornelissen as outlined by @service-paradis do you think we should use the wordmark or just the spark here? About the hex value, I'm a bit confused on why the brand color is suggested and not the actual logo color, though that may be a question better asked in a separate issue. If we're using the wordmark this won't matter anyway. |
Based on the "Logo creation" tab of the Associate Brand Center (linked by @service-paradis) it seems to me that we should include the wordmark. By and large people that get the logo through simple icons will be using it "Out of context" 🤔
Primarily because that is what we have done for the other 1900+ icons. On top of that, as @service-paradis, already noted, the color is not embedded in the SVG, and not every user will use the brand color as the color for the SVG. For example, one could choose to embed the SVG in a button that has the brand color as background color. If you want to discuss in more depth I would indeed encourage you to open an issue, after looking for existing issues on the topic as this isn't the first time it has come up. |
Seems like three maintainers are in agreement here so I will revert to the wordmark. I still think "Walmart Blue" (see color palette) would be a better color to represent the brand. This may sound weird, but this is the color that I (and probably most people) think of when they think about Walmart. It is also the one used the most in their stores (on signs, on the storefronts, etc). |
if we are going with the wordmark in full, then I also think Walmart blue is in order rather than Blue Ink or Spark Yellow. |
Just to clarify, I agree blue is the best choice |
@jorgeamadosoria You don't have to keep this updated with the main branch. We only need to update if there is a merge conflict once the PR is ready to committed |
I know, it's a mania :) |
|
Co-authored-by: Eric Cornelissen <ericornelissen@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SVG and metadata look good now, can someone remind me why the trademark symbol is not included?
@ericcornelissen Walmart does not seem to require it for out-of-context logos in their guidelines (in the "Logo creation" section). That link is a guide for internal communications becuase Walmart does not have a brand guideline page for outsiders. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case, this looks good to me 👍 If it turns out we should include the trademark symbol after all we can update it later
Thank you @jorgeamadosoria for your work on this! |
So cool @sachinraja! Love it! |
Issue: closes #6253
Alexa rank: 95
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
I chose
#0071CE
as the hex value because I found the color here. They even call it "Walmart Blue." It also shows up a few places throughout their site (see https://walmart.com below the navbar for a similar color and https://corporate.walmart.com/ navbar for the exact color). This logo includes the registered trademark symbol as I found it in the logos used on their site.