Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pubg #7199

Merged
merged 6 commits into from Mar 9, 2022
Merged

Pubg #7199

merged 6 commits into from Mar 9, 2022

Conversation

jorgeamadosoria
Copy link
Contributor

pubg

issue: #5001

This icon is for the desktop game, but they are similar enough that I think this one can cover both (Mobile version just adds "mobile" below the icon).

Color taken from the css for the header in: https://www.pubgmobile.com/en/event/brandassets/

@jorgeamadosoria jorgeamadosoria linked an issue Mar 7, 2022 that may be closed by this pull request
@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 7, 2022
@sachinraja
Copy link
Contributor

It seems like this is mixing up NetBox with PUBG. Also there is no need to request reviews on new PRs, we'll get to it when we see it.

@jorgeamadosoria
Copy link
Contributor Author

It seems like this is mixing up NetBox with PUBG. Also there is no need to request reviews on new PRs, we'll get to it when we see it.

removed NetBox.

Also, this is not really a new PR: This is a replacement for an old abandoned PR that has been waiting review for almost a year now. I closed that and created this new one in its stead.

Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Nice @jorgeamadosoria, love it!

@jorgeamadosoria jorgeamadosoria merged commit dc67e7e into simple-icons:develop Mar 9, 2022
@github-actions github-actions bot mentioned this pull request Mar 13, 2022
mondeja added a commit that referenced this pull request Mar 13, 2022
# New Icons

- IBM Cloud (#6746)
- PUBG (#7199)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PUBGm
3 participants