Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Deluge icon #7262

Merged
merged 10 commits into from Nov 18, 2023
Merged

Add Deluge icon #7262

merged 10 commits into from Nov 18, 2023

Conversation

noam09
Copy link
Contributor

@noam09 noam09 commented Mar 25, 2022

deluge

Issue:
Similarweb rank:

126,508

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 25, 2022
@sachinraja sachinraja mentioned this pull request Apr 7, 2022
Closed
4 tasks
@sisp sisp added the in discussion There is an ongoing discussion that should be finished before we can continue label May 20, 2022
@sisp
Copy link
Contributor

sisp commented May 20, 2022

I'd like to wait with reviewing this PR until the discussion about Torrent clients in #6246 has concluded.

@PratyushJayachandran
Copy link
Member

Since this is merged: #6246

Can we add this icon now? @simple-icons/icon-review

LitoMore
LitoMore requested changes Sep 16, 2023
View reviewed changes
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I found some differences with the outline mode.

@PratyushJayachandran
Update icons/deluge.svg
d95221f 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
adamrusted
adamrusted approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon itself is perfect, I'll just update the JSON slightly and get this merged.

_data/simple-icons.json Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
@adamrusted adamrusted merged commit 59234dd into simple-icons:develop Nov 18, 2023
3 checks passed
@github-actions github-actions bot removed the in discussion There is an ongoing discussion that should be finished before we can continue label Nov 18, 2023
@github-actions github-actions bot mentioned this pull request Nov 19, 2023
Merged
mondeja added a commit that referenced this pull request Nov 19, 2023
@mondeja
Release 17 new icons and 4 updated icons (v9.21.0)
fa40e28 
# New Icons

- Blackmagic Design (#5488)
- Deluge (#7262)
- Diners Club (#9868)
- Fairphone (#8268)
- Hilton Hotels &amp; Resorts (#9820)
- Insta360 (#9546)
- Material for MkDocs (#9851)
- Mermaid (#9808)
- mpv (#7293)
- PDM (#9805)
- PlatformIO (#8938)
- PortSwigger (#9869)
- Rye (#9844)
- Satellite (#9468)
- Tricentis (#9219)
- Webex (#8613)
- Wells Fargo (#8867)

# Updated Icons

- Hack The Box (#9661)
- Read.cv (#9784)
- SQLAlchemy (#9850)
- Thunderbird (#9761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PratyushJayachandran PratyushJayachandran PratyushJayachandran left review comments

@LitoMore LitoMore LitoMore requested changes

@adamrusted adamrusted adamrusted approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@noam09 @sisp @PratyushJayachandran @adamrusted @LitoMore