Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new icon for Webex #8613

Merged
merged 9 commits into from Nov 15, 2023
Merged

Add new icon for Webex #8613

merged 9 commits into from Nov 15, 2023

Conversation

askmrsinh
Copy link
Contributor

@askmrsinh askmrsinh commented May 4, 2023 •
edited

Issue: closes #5943

Similarweb rank: 1710

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Webex underwent a major rebrand quite some time ago. I created internal request to add this icon to simple-icon package.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label May 4, 2023
LitoMore
LitoMore requested changes May 7, 2023
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
@askmrsinh askmrsinh requested a review from LitoMore May 7, 2023 09:45
@LitoMore
Copy link
Member

LitoMore commented May 9, 2023 •
edited

@askmrsinh I don't have access to the page https://resources.webex.com/webex/brand-exchange-collection

Could you share the logo resource and guidelines here?

@askmrsinh
Copy link
Contributor Author

askmrsinh commented May 20, 2023 •
edited

@LitoMore
The original logo/icon is a colored 3D helix with gradients as seen here and here (favicon). The 2D icon can be found on Cisco Momentum Design's website: https://momentum.design/icons and Github repository: https://github.com/momentum-design/momentum-ui/blob/master/icons-rebrand/svg/webex-helix-filled.svg.

The guidelines doc (PDF) is very extensive and is marked for internal use. Let me know in case you are looking for something in particular.

@LitoMore
Copy link
Member

LitoMore commented Jun 3, 2023 •
edited

2023-06-02 at 23 59 30@2x

@askmrsinh I can see some differences between the one you processed and https://github.com/momentum-design/momentum-ui/blob/master/icons-rebrand/svg/webex-helix-filled.svg.

Could you check this?

@askmrsinh
Copy link
Contributor Author

@LitoMore

The asset came directly from the UI team at Cisco and is the most up-to date.

PratyushJayachandran
PratyushJayachandran previously requested changes Sep 17, 2023
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
icons/webex.svg Show resolved Hide resolved
@PratyushJayachandran PratyushJayachandran dismissed their stale review September 24, 2023 20:26

Reviewer submitted suggestions to be merged

@PratyushJayachandran
Update icons/webex.svg
075c2b3 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@adamrusted adamrusted merged commit 93c3c77 into simple-icons:develop Nov 15, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Nov 19, 2023
Merged
mondeja added a commit that referenced this pull request Nov 19, 2023
@mondeja
Release 17 new icons and 4 updated icons (v9.21.0)
fa40e28 
# New Icons

- Blackmagic Design (#5488)
- Deluge (#7262)
- Diners Club (#9868)
- Fairphone (#8268)
- Hilton Hotels &amp; Resorts (#9820)
- Insta360 (#9546)
- Material for MkDocs (#9851)
- Mermaid (#9808)
- mpv (#7293)
- PDM (#9805)
- PlatformIO (#8938)
- PortSwigger (#9869)
- Rye (#9844)
- Satellite (#9468)
- Tricentis (#9219)
- Webex (#8613)
- Wells Fargo (#8867)

# Updated Icons

- Hack The Box (#9661)
- Read.cv (#9784)
- SQLAlchemy (#9850)
- Thunderbird (#9761)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PratyushJayachandran PratyushJayachandran PratyushJayachandran left review comments

@adamrusted adamrusted adamrusted approved these changes

@LitoMore LitoMore Awaiting requested review from LitoMore

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webex
4 participants
@askmrsinh @LitoMore @adamrusted @PratyushJayachandran