Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Norton icon #7708

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Add Norton icon #7708

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6c5cf63
Add norton.svg
halacoglu Aug 27, 2022
7c1da6e
Update simple-icons.json
halacoglu Aug 27, 2022
1207777
Fix source
PratyushJayachandran Sep 16, 2023
6bd979d
Merge branch 'develop' into norton
PratyushJayachandran Sep 16, 2023
95271a5
Fix icon
PratyushJayachandran Sep 16, 2023
7fb483b
Merge branch 'develop' into norton
Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions _data/simple-icons.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7383,6 +7383,11 @@
"source": "https://nordvpn.com/press-area/",
"guidelines": "https://nordvpn.com/press-area/"
},
{
"title": "Norton",
"hex": "FFE01A",
"source": "https://static.nortoncdn.com/static/ngpcdn/static/ngp2022.3.14.8/dist/images/norton-black.svg"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From where exactly did you extract this URL? I only see the the logo in the navbar of https://us.norton.com/, and the file URL there is https://us.norton.com/content/dam/norton/logo/logo_norton_d.svg.

According to the source guidelines of the contribution guide:

If the SVG is sourced from:
...

  • Company website: If the SVG is found on the company website (but there is no branding page) the source URL should link to a common page, such as the home page or about page, that includes the source image and not the image file itself.
    ...

For this reason, please update the source URL to the website on which includes the source image instead of using the URL of the image file.

PratyushJayachandran marked this conversation as resolved.
Show resolved Hide resolved
},
{
"title": "Norwegian",
"hex": "D81939",
Expand Down
1 change: 1 addition & 0 deletions icons/norton.svg
View file
Open in desktop
PratyushJayachandran marked this conversation as resolved.
Show resolved Hide resolved
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.