Add Norton icon
#7708
Merged
Add Norton icon
#7708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
new icon
sisp
suggested changes
Aug 31, 2022
There was a problem hiding this comment.
Thanks for your contribution, @halacoglu! 🙏
I see no notable difference between the source image and your derived icon: 👍
I have one request for change regarding the source URL though.
_data/simple-icons.json
Outdated
| { | ||
| "title": "Norton", | ||
| "hex": "FFE01A", | ||
| "source": "https://static.nortoncdn.com/static/ngpcdn/static/ngp2022.3.14.8/dist/images/norton-black.svg" |
There was a problem hiding this comment.
From where exactly did you extract this URL? I only see the the logo in the navbar of https://us.norton.com/, and the file URL there is https://us.norton.com/content/dam/norton/logo/logo_norton_d.svg.
According to the source guidelines of the contribution guide:
If the SVG is sourced from:
...
- Company website: If the SVG is found on the company website (but there is no branding page) the source URL should link to a common page, such as the home page or about page, that includes the source image and not the image file itself.
...
For this reason, please update the source URL to the website on which includes the source image instead of using the URL of the image file.
adamrusted
requested changes
Aug 16, 2023
Co-authored-by: Adam Rusted <hello@adamrusted.me>
|
@adamrusted Can you give another look |
adamrusted
approved these changes
Oct 6, 2023
mondeja
added a commit
that referenced
this pull request
Oct 8, 2023
# New Icons - Arc (#9569) - Codeium (#9644) - DJI (#9547) - NextUI (#9669) - Norton (#7708) - OpenText (#7846) - Studyverse (#9612) - Turso (#9686) - Void Linux (#9394) # Updated Icons - Hack Club (#9628) - Hack The Box (#9628) - HackerOne (#9628) - HackerRank (#9628) - Handlebars.js (#9628) - Handshake (#9628) - Heroku (#9628) - Hetzner (#9628) - Patreon (#9689) - Yoast (#9398)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Norton is an anti-virus or anti-malware software product, developed and distributed by NortonLifeLock since 1991 as part of its Norton family of computer security products.
Similarweb rank: 2,128
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description
#FFE01A.