Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vala icon #7881

Merged
merged 7 commits into from
Jan 28, 2023
Merged

Add Vala icon #7881

merged 7 commits into from
Jan 28, 2023

Conversation

glerroo
Copy link
Contributor

@glerroo glerroo commented Sep 29, 2022

image

Issue: closes #7877

Similarweb rank: 1,910,584

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 29, 2022
@LitoMore
Copy link
Member

LitoMore commented Oct 6, 2022 •
edited

CleanShot 2022-10-06 at 19 37 58@2x@glerroo In this case, we could use their full brand instead of the single V.

Or remove its square background, just use V only. It's better for badges.

@LitoMore LitoMore changed the title Vala Add Vala icon Oct 6, 2022
@glerroo
Copy link
Contributor Author

glerroo commented Oct 8, 2022 •
edited

@LitoMore I created this version with the full branding without the rectangular background or is better with it.
image

For Wikimedia the base color is middle plum #75507B but the website vala.dev use the color #7239B3. Do I use the first or the second? For me the latter looks better.

@dirien dirien added the in discussion There is an ongoing discussion that should be finished before we can continue label Oct 13, 2022
@dirien
Copy link
Member

dirien commented Nov 25, 2022

Hi @glerroo, I like the V version more! Like the favicon of the website.

@glerroo
Copy link
Contributor Author

glerroo commented Jan 21, 2023

Hi @LitoMore and @dirien i made this other version as suggested, the V without the square background.

vala

The base color is that used in the website vala.dev, #7239B3.

@dirien
Copy link
Member

dirien commented Jan 21, 2023

@glerroo cool! I will check this tomorrow! 👍

@glerroo
Copy link
Contributor Author

glerroo commented Jan 21, 2023

@dirien I don't have updated the vala.svg file in the repo, i wait your check or upload now the new version.

@dirien
Copy link
Member

dirien commented Jan 21, 2023

@glerroo go and upload it! I like the V!

@glerroo
Copy link
Contributor Author

glerroo commented Jan 21, 2023

@dirien Uploaded! 👍

dirien
dirien approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @glerroo ,

Thanks for your contribution to simple-icons!

It's a perfect fit:
image

@dirien dirien merged commit ccd88e7 into simple-icons:develop Jan 28, 2023
@github-actions github-actions bot removed the in discussion There is an ongoing discussion that should be finished before we can continue label Jan 28, 2023
@github-actions github-actions bot mentioned this pull request Jan 29, 2023
Merged
mondeja added a commit that referenced this pull request Jan 30, 2023
@mondeja
Release 4 new icons and 1 updated icon (v8.4.0)
c53cf80 
# New Icons

- DaisyUI (#8265)
- ITVx (#8270)
- TOML (#8271)
- Vala (#7881)

# Updated Icons

- Nuxt.js (#8115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirien dirien dirien approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Vala Icon
3 participants
@glerroo @LitoMore @dirien