-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Modrinth icon #8101
Add Modrinth icon #8101
Conversation
I apologize. I'm not that used to working with svg files. I had apparently not succeeded in getting the icon maximized in the viewbox. I thought Inkscape had done that for me when I asked it to resize it, but it was apparently a bit off. I need to read up a bit on how to fix this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but could the color be changed to either #1bd96a
(dark mode brand color) or #00af5c
(light mode brand color)? Whichever looks better in this context.
@triphora Done. Also updated the preview. |
What is the process for getting this merged? |
Also, @triphora, I see you are associated with Modrinth. Can we consider your approval an official acknowledgement? According to the simple-icons documentation, having such an approval might speed up the process. |
Yes, you may. It's been on my personal to-do list to PR this, but I wasn't able to figure out how to merge the paths without breaking it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This need to be merged asap
Yeah, that was tricky. I'm not an SVG guru myself either, but I found a hint about using the fill bucket tool in Inkscape, and that did the trick. It created a new shape based on what is visible "to the human eye", which was just what was needed here. |
@dirien Sorry for the ping, but I don't know else how to get this PR to the attention of someone with merge permissions. I believe this PR is ready for merge. We have an official review from the Modrinth team (#8101 (comment)). The automatic tests pass. All official requirements are checked off. |
Hi @magicus, I will look tomorrow (CET time) as first thing into it! Thanks for the contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ho @magicus,
i see some differences to the reference icon (favicon.svg) I will approve this PR as the Modrinth team gave green light for your icon!
Thanks for contributing.
Issue: closes #7488
Similarweb rank: #48410
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
According to the two previously closed PRs (#7579 and #7688) trying to incorporate the Modrinth logo, the full logo was deemed too complex, and the simpler "favicon" (still svg based) should be used instead. Unfortunately this used design-wise complex objects and clipping, which made it tricky to convert into a single path as required by simple-icons.
I solved it by following a hint about using Inkscape's fill bucket.
The color is the official light mode branding color.