Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Misskey icon #8412

Merged
merged 4 commits into from May 24, 2023
Merged

Add Misskey icon #8412

merged 4 commits into from May 24, 2023

Conversation

arrow2nd
Copy link
Contributor

misskey

Issue: closes #8410

Similarweb rank:
repository has 5.7k stars and the largest server "misskey.io" has a Global Rank of 43,396

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Icons can be found on the following pages.

https://misskey-hub.net/en/appendix/assets.html#icon

The brand colors were extracted from the SVG image of the logo in the repository's README.
In addition, misskey.svg was created using the portion of this SVG image that had already been split.

screenshot

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 10, 2023
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2023-04-02 at 16 36 47@2x

@arrow2nd I found some differences. Could you try with higher precision?

@arrow2nd
Copy link
Contributor Author

arrow2nd commented Apr 2, 2023

Thanks for the review.
I changed the Number precision of SVGOMG from 3 to 5.

@LitoMore
Copy link
Member

LitoMore commented Apr 2, 2023

CleanShot 2023-04-02 at 21 53 31@2x

@arrow2nd Seems differences are still there. Please make sure you are working on the original one with precision 5.

I tried on my local, and the precision 3 is enough.

CleanShot 2023-04-02 at 22 00 49@2x

@arrow2nd arrow2nd closed this Apr 8, 2023
@arrow2nd
Copy link
Contributor Author

arrow2nd commented Apr 8, 2023

Hmm...

I tried several times with the original SVG and could not successfully correct the misalignment.
I think this is due to my unfamiliarity with editing SVGs.

I would like to work on this issue, but my personal life has become too busy lately to devote the time, so I would like to close this pull request.

I am so sorry for giving up in the middle of this review, even though you had reviewed it.

@arrow2nd arrow2nd deleted the misskey branch April 8, 2023 14:58
@LitoMore
Copy link
Member

LitoMore commented Apr 8, 2023

@arrow2nd It's ok. Let me continue on the work.

@arrow2nd arrow2nd restored the misskey branch April 8, 2023 16:06
@arrow2nd arrow2nd reopened this Apr 8, 2023
@arrow2nd
Copy link
Contributor Author

arrow2nd commented Apr 8, 2023

I'm sorry, thank you.
Reopened.

@LitoMore
Copy link
Member

2023-05-24 at 19 18 12@2x

Fixed now.

@LitoMore LitoMore merged commit 1b809b7 into simple-icons:develop May 24, 2023
4 checks passed
@arrow2nd arrow2nd deleted the misskey branch May 27, 2023 05:56
mondeja added a commit that referenced this pull request May 28, 2023
# New Icons

- Ameba (#8655)
- Compiler Explorer (#8646)
- Frontify (#8634)
- Lightning (#8415)
- Misskey (#8412)
- MonoGame (#8614)
- MUBI (#8657)
- Payload CMS (#8633)
- Trailforks (#8635)

# Updated Icons

- Roblox (#8676)

# Removed Icons

- Alitalia (#8310)
- Linode (#8549)
- MonoGames (#8614)
- PyTorch Lightning (#8415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Misskey Icon
3 participants