Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Roblox icon #8676

Merged
merged 11 commits into from May 24, 2023
Merged

Update Roblox icon #8676

merged 11 commits into from May 24, 2023

Conversation

RyanLua
Copy link
Contributor

@RyanLua RyanLua commented May 20, 2023

roblox

Issue: closes #8313

Similarweb rank: 35

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Update the icon to use the new Roblox logo as mentioned in this blog post from Roblox on "Our Refreshed Logo", with the current logo, used in Simple Icons, being the 2018-2022 logo. This pull request updates it to the present one. I kept the same 000000 hex color as it still remains the same brand color from The Roblox Brand Guidelines. I took the SVG from roblox.com/home's HTML as a path, unfortunately I could not find the direct URL to just the SVG to use as source so it has been updated to the full logo's link.

The present logo has a larger hole in the "O", which the current one lacks so this pull request will correct it to the present logo.

image

@github-actions github-actions bot added the update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both label May 20, 2023
@LitoMore
Copy link
Member

CleanShot 2023-05-22 at 13 34 54@2x

@RyanLua I can see some differences. The expected size should be:

CleanShot 2023-05-22 at 13 36 01@2x

But yours:

CleanShot 2023-05-22 at 13 36 13@2x

Please make sure the picture is not stretched.

@RyanLua
Copy link
Contributor Author

RyanLua commented May 22, 2023

CleanShot 2023-05-22 at 13 34 54@2x

@RyanLua I can see some differences. The expected size should be:

CleanShot 2023-05-22 at 13 36 01@2x

But yours:

CleanShot 2023-05-22 at 13 36 13@2x

Please make sure the picture is not stretched.

For clarification it should be 23.997 pixels for the height? Just want to make sure.

@LitoMore
Copy link
Member

LitoMore commented May 22, 2023

@RyanLua Yes. The original icon size is not an actual square.

Please make sure to enable the proportion lock when resizing.

Signed-off-by: Ryan Lua <80087248+RyanLua@users.noreply.github.com>
Signed-off-by: Ryan Lua <80087248+RyanLua@users.noreply.github.com>
@RyanLua
Copy link
Contributor Author

RyanLua commented May 23, 2023

Should be fixed. For some reason I got the below result with proportion lock.

image

@LitoMore
Copy link
Member

LitoMore commented May 23, 2023

@RyanLua It should be 24 x 23.997.

Kapture.2023-05-24.at.06.06.36.mp4

I took the SVG from roblox.com/home as you mentioned in the description.

@RyanLua
Copy link
Contributor Author

RyanLua commented May 23, 2023

@RyanLua It should be 24 x 23.997.

Kapture.2023-05-24.at.06.06.36.mp4
I took the SVG from roblox.com/home as you mentioned in the description.

@LitoMore That's quite odd.

I just zoomed in around 250% on the support page which until it showed the truncated "O" variation of the logo. Saved the svg from the website and then scaled it down from there.

I maybe should have mentioned that step before. I showed it on the support page as you don't need to be logged into Roblox to get the different variant of the Roblox logo. They could just be using a different "O" for the full and single variant of the logos.


The shortened logo between the home and support are the exact same except for maybe color for dark and light themes.

image

How I scaled the logo and sourced it:

Recording.2023-05-23.152435.mp4
Recording.2023-05-23.152338.mp4

@LitoMore
Copy link
Member

@RyanLua OK, please share the SVG file that you're using. I will use yours as a reference.

@RyanLua
Copy link
Contributor Author

RyanLua commented May 23, 2023

@RyanLua OK, please share the SVG file that you're using. I will use yours as a reference.

Here are the files from the Roblox site, unedited. Both light and dark theme variants.

robloxref
robloxref2

Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2023-05-25 at 02 50 22@2x

@RyanLua Looks good. Thank you for contributing.

@LitoMore LitoMore merged commit b3626b2 into simple-icons:develop May 24, 2023
4 checks passed
mondeja added a commit that referenced this pull request May 28, 2023
# New Icons

- Ameba (#8655)
- Compiler Explorer (#8646)
- Frontify (#8634)
- Lightning (#8415)
- Misskey (#8412)
- MonoGame (#8614)
- MUBI (#8657)
- Payload CMS (#8633)
- Trailforks (#8635)

# Updated Icons

- Roblox (#8676)

# Removed Icons

- Alitalia (#8310)
- Linode (#8549)
- MonoGames (#8614)
- PyTorch Lightning (#8415)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update icon/data Issues or pull requests regarding icons that are outdated, this can be the SVG or color or both
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Roblox logo
2 participants