Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruff icon #8576

Merged
merged 6 commits into from Apr 27, 2023
Merged

Add Ruff icon #8576

merged 6 commits into from Apr 27, 2023

Conversation

MicaelJarniac
Copy link
Contributor

@MicaelJarniac MicaelJarniac commented Apr 26, 2023 •
edited

ruff

Issue: closes #8366

Repo: GitHub Repo stars

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Apr 26, 2023
@MicaelJarniac
Copy link
Contributor Author

I believe transform isn't supported, will fix it.

@MicaelJarniac MicaelJarniac marked this pull request as ready for review April 26, 2023 19:28
@MicaelJarniac
Copy link
Contributor Author

I saw the linting errors and will try to fix them.

One of them seems to be because the GitHub web editor added a new line at the end of the file, which should be easy to fix.

The other one seems to be about the icon not being exactly centered I guess, will see if I can figure it out.

@MicaelJarniac
Copy link
Contributor Author

Well, I've removed the newline for now. Am not quite sure how to fix the other issue, though.

@MicaelJarniac
Copy link
Contributor Author

I think I've fixed it.

LitoMore
LitoMore approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@LitoMore LitoMore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2023-04-27 at 21 29 55@2x

@MicaelJarniac This looks good! Thank you for contributing!

@LitoMore LitoMore changed the title Add Ruff icon (#8366) Add Ruff icon Apr 27, 2023
@LitoMore LitoMore merged commit f149b1f into simple-icons:develop Apr 27, 2023
3 checks passed
@MicaelJarniac MicaelJarniac deleted the patch-1 branch April 27, 2023 15:00
@github-actions github-actions bot mentioned this pull request Apr 30, 2023
Merged
mondeja added a commit that referenced this pull request Apr 30, 2023
@mondeja
Release 7 new icons and 3 updated icons (v8.12.0)
f67750a 
# New Icons

- AFFiNE (#8543)
- ArcGIS (#8477)
- Cardano (#8541)
- Contao (#8571)
- ESRI (#8477)
- Mongoose (#8537)
- Ruff (#8576)

# Updated Icons

- Flathub (#8561)
- Polkadot (#8523)
- Supabase (#8536)
@dushmanta05
Copy link
Contributor

Hi, I'm facing linting errors. How can I fix them? Can you please help? Thanks.

@MicaelJarniac
Copy link
Contributor Author

Hi, I'm facing linting errors. How can I fix them? Can you please help? Thanks.

How's that related to this PR?

@dushmanta05
Copy link
Contributor

Sorry sir.

@MicaelJarniac
Copy link
Contributor Author

@dushmanta05 I think you can open a discussion to ask for help:
https://github.com/simple-icons/simple-icons/discussions/categories/help-with-svgs
Link to your PR and include the original SVG file, your attempt, and the linting errors you're getting.

@dushmanta05
Copy link
Contributor

Okay, thank you for the information; I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LitoMore LitoMore LitoMore approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruff
3 participants
@MicaelJarniac @dushmanta05 @LitoMore