Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESRI and ArcGIS icons #8477

Merged
merged 6 commits into from
Apr 29, 2023
Merged

Add ESRI and ArcGIS icons #8477

merged 6 commits into from
Apr 29, 2023

Conversation

geoyee
Copy link
Contributor

@geoyee geoyee commented Mar 28, 2023

esri

arcgis

Issue: closes #8476

Similarweb rank:

Global Rank is 2,257

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Edited from the official SVG icons.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Mar 28, 2023
dirien
dirien requested changes Apr 7, 2023
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @geoyee,

can you check the Arcgis:
image

and ESRI

image

@geoyee
Copy link
Contributor Author

geoyee commented Apr 7, 2023

Hi @geoyee,

can you check the Arcgis: image

and ESRI

image

NP, i will update them

@geoyee
Copy link
Contributor Author

geoyee commented Apr 7, 2023

@dirien i believe that these icons should be correctly. please review again, thank you 😄

@geoyee geoyee requested a review from dirien April 7, 2023 14:34
dirien
dirien approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @geoyee,

Thanks for your contribution to simple-icons!

It's a perfect fit:
image

image

@dirien dirien merged commit 7d186cd into simple-icons:develop Apr 29, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Apr 30, 2023
Merged
mondeja added a commit that referenced this pull request Apr 30, 2023
@mondeja
Release 7 new icons and 3 updated icons (v8.12.0)
f67750a 
# New Icons

- AFFiNE (#8543)
- ArcGIS (#8477)
- Cardano (#8541)
- Contao (#8571)
- ESRI (#8477)
- Mongoose (#8537)
- Ruff (#8576)

# Updated Icons

- Flathub (#8561)
- Polkadot (#8523)
- Supabase (#8536)
This was referenced May 1, 2023
Closed
Closed
@geoyee geoyee deleted the arcgis branch February 15, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirien dirien dirien approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: ESRI and ArcGIS
2 participants
@geoyee @dirien