Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adoptium icons added #8764

Closed
wants to merge 6 commits into from
Closed

Adoptium icons added #8764

wants to merge 6 commits into from

Conversation

hendrikebbers
Copy link
Contributor

@hendrikebbers hendrikebbers commented Jun 9, 2023 •
edited by adamrusted

Issue: #8643

**Similarweb rank:**66,322

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jun 9, 2023
PratyushJayachandran
PratyushJayachandran requested changes Jun 10, 2023
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the logos seems to have some issue and I was not able to optimize it in SVGOMG

It would also be better to add each logo as a separate pull request.

icons/eclipseadoptium.svg Outdated Show resolved Hide resolved
icons/eclipseaqavit.svg Outdated Show resolved Hide resolved
icons/eclipsetemurin.svg Outdated Show resolved Hide resolved
@RiteshK-611
Copy link
Contributor

RiteshK-611 commented Jun 12, 2023 •
edited

Here svg files must be in this format

<svg role="img' viewBox"0 0 24 24" xmlns="http://www.w3.org/2000/svg"><title>.....</title><path d="....." /></svg>

hendrikebbers and others added 3 commits June 12, 2023 11:44
@hendrikebbers @PratyushJayachandran
Update icons/eclipseadoptium.svg
973aee4 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@hendrikebbers @PratyushJayachandran
Update icons/eclipseaqavit.svg
0487b00 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@hendrikebbers @PratyushJayachandran
Update icons/eclipsetemurin.svg
bb5b5af 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@hendrikebbers
Copy link
Contributor Author

@PratyushJayachandran @RiteshK-611 thanks for the feedback. I used SVGOMG to minimize the size.

@hendrikebbers
Copy link
Contributor Author

Will create individual PRs

@hendrikebbers hendrikebbers mentioned this pull request Jun 12, 2023
Merged
3 tasks
@hendrikebbers
Copy link
Contributor Author

I created #8791 for the first logo. Once that is merged I will create PRs for the missing 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PratyushJayachandran PratyushJayachandran PratyushJayachandran requested changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hendrikebbers @RiteshK-611 @PratyushJayachandran