Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Eclipse Adoptium icon #8791

Merged
merged 23 commits into from Jun 22, 2023
Merged

Add Eclipse Adoptium icon #8791

merged 23 commits into from Jun 22, 2023

Conversation

hendrikebbers
Copy link
Contributor

@hendrikebbers hendrikebbers commented Jun 12, 2023 •
edited

eclipseadoptium

Issue: part of ##8643 (will create 4 PRs in total as discussed at #8764)

Similarweb rank: 66,322

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

hendrikebbers and others added 7 commits June 9, 2023 09:52
@hendrikebbers
adoptium logos added
798ad88
@hendrikebbers
svgomg used
9c0576c
@hendrikebbers
box size
c7db6d9
@hendrikebbers @PratyushJayachandran
Update icons/eclipseadoptium.svg
973aee4 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@hendrikebbers @PratyushJayachandran
Update icons/eclipseaqavit.svg
0487b00 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@hendrikebbers @PratyushJayachandran
Update icons/eclipsetemurin.svg
bb5b5af 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@hendrikebbers
removed all but Adoptium
ef931c1
@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jun 12, 2023
@hendrikebbers hendrikebbers mentioned this pull request Jun 12, 2023
Closed
3 tasks
hendrikebbers and others added 2 commits June 13, 2023 09:35
@hendrikebbers @PratyushJayachandran
Update _data/simple-icons.json
6525134 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@hendrikebbers
Merge branch 'develop' into eclipse-adoptium
81866e8
@hendrikebbers
Copy link
Contributor Author

@PratyushJayachandran have I done something wrong? The build always breaks.

@PratyushJayachandran
Copy link
Member

@PratyushJayachandran have I done something wrong? The build always breaks.

Try removing that trailing slash. But I do not know about the other errors. Also try merging develop into your branch.

I'll check in more detail in the weekend if it still fails or maybe the maintainers will chime in by then.

hendrikebbers and others added 2 commits June 16, 2023 08:02
@hendrikebbers
Merge branch 'develop' into eclipse-adoptium
1b918bf
@hendrikebbers @PratyushJayachandran
Update _data/simple-icons.json
fded84a 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
PratyushJayachandran
PratyushJayachandran requested changes Jun 20, 2023
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SVG had too many mistakes. I fixed and checked on local. Seems to be passing on my system.

icons/eclipseadoptium.svg Outdated Show resolved Hide resolved
@hendrikebbers @PratyushJayachandran
Update icons/eclipseadoptium.svg
77fa9f9 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@hendrikebbers
Copy link
Contributor Author

@PratyushJayachandran thank you. I will try to fix all that in text editor for the next icons.

PratyushJayachandran
PratyushJayachandran requested changes Jun 21, 2023
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please read my comments and make the changes. I checked and they pass the tests with my suggested changes.
I feel like #A80D55 from their guideline would be a more appropriate color after I checked the dominant and average colors in the logo, but that is just my opinion.

_data/simple-icons.json Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
@hendrikebbers @PratyushJayachandran
Update _data/simple-icons.json
9c3907a 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
hendrikebbers and others added 5 commits June 22, 2023 11:14
@hendrikebbers @PratyushJayachandran
Update _data/simple-icons.json
83e1473 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@hendrikebbers @PratyushJayachandran
Update _data/simple-icons.json
773a101 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@hendrikebbers @PratyushJayachandran
Update _data/simple-icons.json
dbe9092 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@hendrikebbers @PratyushJayachandran
Update _data/simple-icons.json
59dd838 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
@hendrikebbers @PratyushJayachandran
Update _data/simple-icons.json
a6b18db 
Co-authored-by: PratyushJayachandran <35000807+PratyushJayachandran@users.noreply.github.com>
PratyushJayachandran
PratyushJayachandran approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, it passes all checks now. Thanks for implementing my suggestions.

LitoMore
LitoMore approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@LitoMore LitoMore left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before After

I have pruned some redundant control points for you to make it smaller file size.

@LitoMore LitoMore changed the title Eclipse adoptium icon added Add Eclipse Adoptium icon Jun 22, 2023
@LitoMore LitoMore merged commit 3b219a0 into simple-icons:develop Jun 22, 2023
3 checks passed
@PratyushJayachandran
Copy link
Member

Before After

I have pruned some redundant control points for you to make it smaller file size.

I had noticed that while adding my suggestion but that is how it was in the branding PDF. Probably some mistake happened.

Btw @LitoMore can you set Contributing to No by default when creating issues. There are a lot many requests with yes selected and no contributions from the requestor. Anyone willing to contribute may assume it will be done by the requestor themselves and hence not make a contribution. Sorry for off topic comment. I don't know how else to convey this.

@LitoMore
Copy link
Member

Hi @PratyushJayachandran, thank you for helping others on this project.

It doesn't matter they select Yes or No. You can just assume they don't have free time right now.

You can always create a PR even they selected Yes.

Thank you again for your contributions! Cheers!

@PratyushJayachandran
Copy link
Member

Hi @PratyushJayachandran, thank you for helping others on this project.
You can always create a PR even they selected Yes.

Thank you again for your contributions! Cheers!

Understood. Glad to contribute 😊

@github-actions github-actions bot mentioned this pull request Jun 25, 2023
Merged
mondeja added a commit that referenced this pull request Jun 25, 2023
@mondeja
Release 21 new icons (v9.3.0)
7f1f860 
# New Icons

- Acura (#8864)
- Amazon Redshift (#8725)
- Appsmith (#7915)
- Babylon.js (#8737)
- Cadillac (#8865)
- DOI (#8525)
- Eclipse Adoptium (#8791)
- Fi (#8380)
- Immich (#8388)
- Kinsta (#8845)
- Logseq (#8311)
- mail.com (#8843)
- MapLibre (#7187)
- MG (#8866)
- Monkeytype (#8846)
- Nginx Proxy Manager (#8769)
- NXP (#8748)
- Prefect (#8772)
- Proton (#7792)
- Skyrock (#8298)
- Trivy (#8855)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LitoMore LitoMore LitoMore approved these changes

@PratyushJayachandran PratyushJayachandran PratyushJayachandran approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hendrikebbers @PratyushJayachandran @LitoMore