Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fluke icon #9062

Merged
merged 5 commits into from
Sep 3, 2023
Merged

Add Fluke icon #9062

merged 5 commits into from
Sep 3, 2023

Conversation

PratyushJayachandran
Copy link
Member

@PratyushJayachandran PratyushJayachandran commented Jul 21, 2023 •
edited by service-paradis
Loading

fluke

Issue: close #9059

Similarweb rank: 53,199. See https://www.similarweb.com/website/fluke.com

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG: Taken from https://www.fluke.com
Color: Taken from logo #ffc20e

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Jul 21, 2023
@adamrusted
Copy link
Member

@simple-icons/maintainers - I think this is an example of needing to keep the ®️ intact, what do we think? Looking at their site and socials, it's used across all brands - with no exceptions.

@adamrusted adamrusted added the in discussion There is an ongoing discussion that should be finished before we can continue label Jul 23, 2023
@PratyushJayachandran
Copy link
Member Author

@simple-icons/maintainers - I think this is an example of needing to keep the ®️ intact, what do we think? Looking at their site and socials, it's used across all brands - with no exceptions.

I removed because they don't use it on their products. The multimeters at least don't have it. Didn't see any guidelines for ® either. But will let maintainers comment on this.

@LitoMore
Copy link
Member

This looks not good to me.

You can find some Fluke products on this page https://www.fluke.com/en-us.

It does not have a wide left padding in the trademark.

I noticed they're using the trademark with ® sign for press releases.

So, let's keep the ® sign to make sure it's consistent with their press releases in this case.

@adamrusted
Copy link
Member

Essentially, let's go with the icon on the homepage including the ®️ - as that's probably the most consistent icon to the products.

@PratyushJayachandran
Copy link
Member Author

Okay I'll do it as is in that case. The wide left padding is another quirk. Even some of their products have it but some of them don't.

@adamrusted
Copy link
Member

It should be mitigated by having the ®️ there... 🤞😅

@PratyushJayachandran
Copy link
Member Author

It should be mitigated by having the ®️ there... 🤞😅

I have fixed it. Attaching updated preview.
fluke

@adamrusted adamrusted requested a review from LitoMore July 23, 2023 21:05
adamrusted
adamrusted approved these changes Sep 3, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @PratyushJayachandran 🎉

@adamrusted adamrusted removed the in discussion There is an ongoing discussion that should be finished before we can continue label Sep 3, 2023
@adamrusted adamrusted merged commit c71ca38 into simple-icons:develop Sep 3, 2023
3 checks passed
@PratyushJayachandran PratyushJayachandran deleted the Add-Fluke branch September 3, 2023 14:56
@github-actions github-actions bot mentioned this pull request Sep 10, 2023
Merged
mondeja added a commit that referenced this pull request Sep 10, 2023
@mondeja
Release 31 new icons and 80 updated icons (v9.14.0)
558ef53 
## New Icons

- Amazon DocumentDB (#8732)
- Amazon Route 53 (#8738)
- AWS Organizations (#8740)
- BSD (#8965)
- C++ Builder (#9401)
- Carrd (#8820)
- CyberDefenders (#9490)
- Docsify (#9465)
- Fluke (#9062)
- Google BigQuery (#9437)
- Google Cloud Composer (#9452)
- Google Data Studio (#9473, #9491)
- Google Earth Engine (#9073)
- H&M (#8104)
- HAL (#9456)
- IndiGo (#9147)
- Interbase (#9403)
- Kedro (#9507)
- Matillion (#9404, #9491)
- Panasonic (#8975)
- Peerlist (#8945)
- RAD Studio (#9402)
- Robinhood (#9120)
- Root Me (#6283)
- SearXNG (#9506)
- SiFive (#9005)
- Sonatype (#9453)
- Ubuntu MATE (#9503)
- Umami (#7546)
- Vaultwarden (#8852)
- Viaplay (#8948)

## Updated Icons

### Icon update

- Aerospike (#9260)
- Alipay (#9491)
- AniList (#9491)
- Apache Cassandra (#9491)
- Backendless (#9360)
- Battle.net (#9345)
- Beijing Subway (#9348)
- Bit (#9349)
- Clarivate (#9360)
- Docusaurus (#9491)
- electron-builder (#9360)
- Fluxus (#9360)
- Hexlet (#9491)
- Honor (#9491, #9360)
- Hootsuite (#9360)
- Jaguar (#9360)
- Leanpub (#9360)
- Lemmy (#9360)
- LGTM (#9360)
- Ludwig (#9360)
- Mumble (#9360)
- Oh Dear (#9360)
- OpenJDK (#9360)
- OpsLevel (#9491)
- osu! (#9510)
- Personio (#9360)
- Reason Studios (#9360)
- SCP Foundation (#9360)
- Sony (#9360)
- Strapi (#9088)
- SWC (#9360)
- Talenthouse (#9360)
- Unity (#9360)
- Vonage (#9360)
- Vuetify (#9445)
- XMPP (#9424)
- Zingat (#9193)
- Zulip (#9360)

### Metadata update

- Tableau (#9508)
- TableCheck (#9508)
- Task (#9508)
- Tasmota (#9508)
- Tata (#9508)
- TED (#9508)
- Teespring (#9508)
- Telegram (#9508)
- Telegraph (#9508)
- Teradata (#9508)
- teratail (#9508)
- Terraform (#9508)
- TestRail (#9508)
- Tether (#9508)
- Tidal (#9508)
- TiddlyWiki (#9508)
- tmux (#9508)
- TNT (#9508)
- Toggl (#9508)
- Toggl Track (#9508)
- Tokyo Metro (#9508)
- Tor Project (#9508)
- Trakt (#9508)
- Transport for Ireland (#9508)
- Treehouse (#9508)
- Trello (#9508)
- Triller (#9508)
- Trino (#9508)
- Tripadvisor (#9508)
- Trivy (#9508)
- Trustpilot (#9508)
- Try It Online (#9508)
- TryHackMe (#9508)
- ts-node (#9508)
- Tumblr (#9508)
- TuneIn (#9508)
- Turkish Airlines (#9508)
- Tutanota (#9508)
- Twitch (#9508)
- Twitter (#9508)
- TYPO3 (#9508)
- WeChat (#9514)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted approved these changes

@LitoMore LitoMore Awaiting requested review from LitoMore

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fluke
3 participants
@PratyushJayachandran @adamrusted @LitoMore