Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CyberDefenders icon #9490

Merged

Conversation

marcosquadross
Copy link
Contributor

cyberdefenders

Issue: closes #9230

Similarweb rank: 267,857

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 4, 2023
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @marcosquadross!
I'm seeing some differences between your PR in black, and the source icon in blue. Looks like you need to make the height of the path itself 24px, and center it on the canvas.
Would you mind taking another look? 🙏

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still spotting a slight difference on this one @marcosquadross. Looks like some points are only 2 decimals of precision. Might be worth exporting higher, and using SVGOMG to optimize to 4 decimals.

icons/cyberdefenders.svg Outdated Show resolved Hide resolved
Co-authored-by: Adam Rusted <hello@adamrusted.me>
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot on now
cyberdefenders-compare

@PratyushJayachandran PratyushJayachandran merged commit 7c4bdf4 into simple-icons:develop Sep 6, 2023
3 checks passed
@marcosquadross marcosquadross deleted the icon-develop branch September 6, 2023 15:02
@marcosquadross marcosquadross restored the icon-develop branch September 6, 2023 15:02
@marcosquadross marcosquadross deleted the icon-develop branch September 7, 2023 00:33
mondeja added a commit that referenced this pull request Sep 10, 2023
## New Icons

- Amazon DocumentDB (#8732)
- Amazon Route 53 (#8738)
- AWS Organizations (#8740)
- BSD (#8965)
- C++ Builder (#9401)
- Carrd (#8820)
- CyberDefenders (#9490)
- Docsify (#9465)
- Fluke (#9062)
- Google BigQuery (#9437)
- Google Cloud Composer (#9452)
- Google Data Studio (#9473, #9491)
- Google Earth Engine (#9073)
- H&amp;M (#8104)
- HAL (#9456)
- IndiGo (#9147)
- Interbase (#9403)
- Kedro (#9507)
- Matillion (#9404, #9491)
- Panasonic (#8975)
- Peerlist (#8945)
- RAD Studio (#9402)
- Robinhood (#9120)
- Root Me (#6283)
- SearXNG (#9506)
- SiFive (#9005)
- Sonatype (#9453)
- Ubuntu MATE (#9503)
- Umami (#7546)
- Vaultwarden (#8852)
- Viaplay (#8948)

## Updated Icons

### Icon update

- Aerospike (#9260)
- Alipay (#9491)
- AniList (#9491)
- Apache Cassandra (#9491)
- Backendless (#9360)
- Battle.net (#9345)
- Beijing Subway (#9348)
- Bit (#9349)
- Clarivate (#9360)
- Docusaurus (#9491)
- electron-builder (#9360)
- Fluxus (#9360)
- Hexlet (#9491)
- Honor (#9491, #9360)
- Hootsuite (#9360)
- Jaguar (#9360)
- Leanpub (#9360)
- Lemmy (#9360)
- LGTM (#9360)
- Ludwig (#9360)
- Mumble (#9360)
- Oh Dear (#9360)
- OpenJDK (#9360)
- OpsLevel (#9491)
- osu! (#9510)
- Personio (#9360)
- Reason Studios (#9360)
- SCP Foundation (#9360)
- Sony (#9360)
- Strapi (#9088)
- SWC (#9360)
- Talenthouse (#9360)
- Unity (#9360)
- Vonage (#9360)
- Vuetify (#9445)
- XMPP (#9424)
- Zingat (#9193)
- Zulip (#9360)

### Metadata update

- Tableau (#9508)
- TableCheck (#9508)
- Task (#9508)
- Tasmota (#9508)
- Tata (#9508)
- TED (#9508)
- Teespring (#9508)
- Telegram (#9508)
- Telegraph (#9508)
- Teradata (#9508)
- teratail (#9508)
- Terraform (#9508)
- TestRail (#9508)
- Tether (#9508)
- Tidal (#9508)
- TiddlyWiki (#9508)
- tmux (#9508)
- TNT (#9508)
- Toggl (#9508)
- Toggl Track (#9508)
- Tokyo Metro (#9508)
- Tor Project (#9508)
- Trakt (#9508)
- Transport for Ireland (#9508)
- Treehouse (#9508)
- Trello (#9508)
- Triller (#9508)
- Trino (#9508)
- Tripadvisor (#9508)
- Trivy (#9508)
- Trustpilot (#9508)
- Try It Online (#9508)
- TryHackMe (#9508)
- ts-node (#9508)
- Tumblr (#9508)
- TuneIn (#9508)
- Turkish Airlines (#9508)
- Tutanota (#9508)
- Twitch (#9508)
- Twitter (#9508)
- TYPO3 (#9508)
- WeChat (#9514)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add cyberdefenders icon
3 participants