Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add HashiCorp Nomad icon #9527

Merged
merged 16 commits into from
Jan 9, 2024
Merged

add HashiCorp Nomad icon #9527

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
48788ad
add HashCorp Nomad icon
thiagogquinto Sep 11, 2023
9ccc7aa
rename svg title
thiagogquinto Sep 11, 2023
a113977
fix Nomad Icon and add requested changes by @adamrusted
thiagogquinto Sep 11, 2023
59d06ed
add: role attribute
thiagogquinto Sep 11, 2023
8f6cd76
reorder attributes
thiagogquinto Sep 11, 2023
990fca7
remove space in attribute role
thiagogquinto Sep 11, 2023
a8b99c8
try no errors
thiagogquinto Sep 11, 2023
36225fc
remove spaces of icons/nomad.svg
thiagogquinto Sep 11, 2023
77609b5
remove line
thiagogquinto Sep 11, 2023
fbc14ee
add requested changes by @adamrusted
thiagogquinto Sep 11, 2023
83e9843
add title tag in /icons/nomad.svg
thiagogquinto Sep 11, 2023
f9efe60
remove line in svg file
thiagogquinto Sep 11, 2023
b0e6958
Merge remote-tracking branch 'upstream/develop' into 9518-HashCorp_Nomad
thiagogquinto Sep 11, 2023
7c18ab0
Merge remote-tracking branch 'upstream/develop' into 9518-HashCorp_Nomad
thiagogquinto Sep 12, 2023
bcd121a
Fix icon issues
PratyushJayachandran Nov 24, 2023
83bf4e8
Merge branch 'develop' into 9518-HashCorp_Nomad
PeterShaggyNoble Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions _data/simple-icons.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8951,6 +8951,12 @@
"hex": "005AFF",
"source": "https://www.nokia.com"
},
{
"title": "Nomad",
"hex": "00CA8E",
"source": "https://www.hashicorp.com/brand",
"guidelines": "https://www.hashicorp.com/brand"
},
{
"title": "Norco",
"hex": "00FF00",
Expand Down
1 change: 1 addition & 0 deletions icons/nomad.svg
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing slight differences around the sides of the icon. Might be worth regenerating from source, or upping the precision to 4 decimals on SVGOMG

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thiagogquinto I still see some differences.
I compared the contributed SVG with this file Nomad_PrimaryLogo_Color_RGB.svg from their brand assets ZIP file.
Can you please take another look and correct the SVG.

Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.