Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add HashiCorp Nomad icon #9527

Merged
merged 16 commits into from Jan 9, 2024
Merged

add HashiCorp Nomad icon #9527

merged 16 commits into from Jan 9, 2024

Conversation

thiagogquinto
Copy link
Contributor

@thiagogquinto thiagogquinto commented Sep 11, 2023 •
edited

nomad

Issue: closes #9518

Similarweb rank:

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 11, 2023
@thiagogquinto thiagogquinto changed the title add HashCorp Nomad icon add HashiCorp Nomad icon Sep 11, 2023
adamrusted
adamrusted requested changes Sep 11, 2023
View reviewed changes
Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @thiagogquinto! 🎉
At a glance, it appears you've stretched the logo in both directions, meaning it's now distorted.
image
Could you please re-work this so that it still maintains it's aspect ratio, but the longest side (height) is 24px? I've also suggested changes to the JSON, to bring in line with our other HashiCorp icons.

_data/simple-icons.json Outdated Show resolved Hide resolved
adamrusted
adamrusted requested changes Sep 11, 2023
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
icons/nomad.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing slight differences around the sides of the icon. Might be worth regenerating from source, or upping the precision to 4 decimals on SVGOMG

PratyushJayachandran
PratyushJayachandran previously requested changes Oct 2, 2023
View reviewed changes
icons/nomad.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thiagogquinto I still see some differences.
I compared the contributed SVG with this file Nomad_PrimaryLogo_Color_RGB.svg from their brand assets ZIP file.
Can you please take another look and correct the SVG.

@adamrusted adamrusted removed their request for review November 15, 2023 15:56
@PeterShaggyNoble
Copy link
Member

Are you still working on this one, @thiagogquinto?

@thiagogquinto
Copy link
Contributor Author

Are you still working on this one, @thiagogquinto?

Sorry for not informing before, but I am not.

@PratyushJayachandran PratyushJayachandran dismissed their stale review November 24, 2023 01:05

I committed some changes

@PratyushJayachandran
Copy link
Member

@simple-icons/icon-review I committed changes to fix the issues. Please review.

@PeterShaggyNoble PeterShaggyNoble added the assessing Issues or icons that require manual input from a project maintainer before work can begin label Dec 7, 2023
@PeterShaggyNoble
Copy link
Member

Labelling this one as assessing Issues or icons that require manual input from a project maintainer before work can begin , pending the outcome of #9979, as its Similarweb rank is well outside our scope and it currently only qualifies on GitHub stars.

@service-paradis
Copy link
Member

Repo is pretty active, ~14.2k Github stars with a not so bad curve, I think this one can be considered for inclusion.

@PeterShaggyNoble PeterShaggyNoble removed the assessing Issues or icons that require manual input from a project maintainer before work can begin label Jan 9, 2024
@PeterShaggyNoble PeterShaggyNoble merged commit bbff244 into simple-icons:develop Jan 9, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 14, 2024
Merged
mondeja added a commit that referenced this pull request Jan 14, 2024
@mondeja
Release 20 new icons and 16 updated icons (v11.1.0)
aaf2f27 
# New Icons

- 7Zip (#7334)
- Asahi Linux (#10245)
- Babelio (#10232)
- Brenntag (#10215)
- Carlsberg Group (#8819)
- CNET (#10228)
- DaVinci Resolve (#9766)
- Edge Impulse (#10201)
- Esoteric Software (#10280)
- Fubo (#10192)
- Hyperskill (#10226)
- Knex.js (#10236)
- Linksys (#10231)
- Nomad (#9527)
- Orange (#10227)
- Paramount+ (#10248)
- Reactive Resume (#10225)
- Solana (#10246)
- Spine (#10239)
- TickTick (#10224)

# Updated Icons

- .ENV (#10255)
- .NET (#10255)
- /e/ (#10269)
- 1001Tracklists (#10260)
- 1Password (#10256)
- 42 (#10278)
- 500px (#10270)
- Aston Martin (#10253)
- Dailymotion (#10216)
- Duolingo (#10111)
- Instagram (#10153)
- LADA (#10155)
- Minecraft (#10242)
- Nintendo (#10263, #10266)
- Revolut (#10238)
- Zapier (#10265)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PratyushJayachandran PratyushJayachandran PratyushJayachandran left review comments

@adamrusted adamrusted adamrusted requested changes

@PeterShaggyNoble PeterShaggyNoble PeterShaggyNoble approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hashicorp Nomad
5 participants
@thiagogquinto @PeterShaggyNoble @PratyushJayachandran @service-paradis @adamrusted