Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: Codeium Icon #9644

Merged
merged 11 commits into from Oct 6, 2023
Merged

Add: Codeium Icon #9644

merged 11 commits into from Oct 6, 2023

Conversation

davidjjohn97
Copy link
Contributor

@davidjjohn97 davidjjohn97 commented Sep 26, 2023 •
edited by service-paradis

Issue: closes #9643 close #9310

Similar Web Rank: 72,794

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Added requested Codeium icon

@davidjjohn97
Update simple-icons.json to include Codeium icon
cfeb239 
Adding changes for codeium icon request in Issue simple-icons#9643
@davidjjohn97
Add files via upload
c8e8067 
Codeium logo svg file
@davidjjohn97
Add files via upload
414e7d1 
Codeium optimized and Viewport corrected svg icon
@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Sep 26, 2023
@Cubik65536
Copy link

Cubik65536 commented Sep 27, 2023 •
edited

The final icon should:
[...]

  • Contain only a single path element.

(From CONTRIBUTING.md)

Your svg seems to contain multiple ones.

And your source should be https://codeium.com not https://codeium.com/.

PratyushJayachandran
PratyushJayachandran requested changes Sep 30, 2023
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidjjohn97 Thank you for starting the PR
Please read https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#adding-or-updating-an-icon and reformat the SVG to match our guidelines

@khou22
Copy link
Contributor

khou22 commented Oct 3, 2023

@davidjjohn97 Thank you for starting the PR Please read https://github.com/simple-icons/simple-icons/blob/develop/CONTRIBUTING.md#adding-or-updating-an-icon and reformat the SVG to match our guidelines

Thanks @PratyushJayachandran and @davidjjohn97 . I will modify the readme to conform to the guidelines some time this week.

@khou22 khou22 mentioned this pull request Oct 4, 2023
Closed
3 tasks
@khou22
Copy link
Contributor

khou22 commented Oct 4, 2023

I opened a new PR (#9681) with an updated SVG logo asset that conforms to the contributor guidelines. Feel free to close this PR. Thanks!

adamrusted
adamrusted requested changes Oct 5, 2023
View reviewed changes
icons/codeium.svg Outdated Show resolved Hide resolved
_data/simple-icons.json Outdated Show resolved Hide resolved
adamrusted
adamrusted reviewed Oct 5, 2023
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
@adamrusted adamrusted changed the title Request: Codeium Icon Add: Codeium Icon Oct 5, 2023
@khou22 khou22 mentioned this pull request Oct 5, 2023
Merged
adamrusted
adamrusted reviewed Oct 5, 2023
View reviewed changes
_data/simple-icons.json Outdated Show resolved Hide resolved
PratyushJayachandran
PratyushJayachandran approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@PratyushJayachandran PratyushJayachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for starting the PR @davidjjohn97 and thanks to @khou22 and @adamrusted for finishing it up 🎉

@PratyushJayachandran PratyushJayachandran merged commit 23527d7 into simple-icons:develop Oct 6, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Oct 8, 2023
Merged
mondeja added a commit that referenced this pull request Oct 8, 2023
@mondeja
Release 9 new icons and 10 updated icons (v9.17.0)
a43b319 
# New Icons

- Arc (#9569)
- Codeium (#9644)
- DJI (#9547)
- NextUI (#9669)
- Norton (#7708)
- OpenText (#7846)
- Studyverse (#9612)
- Turso (#9686)
- Void Linux (#9394)

# Updated Icons

- Hack Club (#9628)
- Hack The Box (#9628)
- HackerOne (#9628)
- HackerRank (#9628)
- Handlebars.js (#9628)
- Handshake (#9628)
- Heroku (#9628)
- Hetzner (#9628)
- Patreon (#9689)
- Yoast (#9398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrusted adamrusted adamrusted requested changes

@khou22 khou22 khou22 left review comments

@PratyushJayachandran PratyushJayachandran PratyushJayachandran approved these changes

Assignees
No one assigned
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Codeium logo request Codeium
5 participants
@davidjjohn97 @Cubik65536 @khou22 @adamrusted @PratyushJayachandran