Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Picxy #9719

Merged
merged 4 commits into from Dec 7, 2023
Merged

Add Picxy #9719

merged 4 commits into from Dec 7, 2023

Conversation

zcraber
Copy link
Contributor

@zcraber zcraber commented Oct 13, 2023

picxy

Similarweb rank: 428,601

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

Colour #2e3192 was picked from the website.

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Oct 13, 2023
@PeterShaggyNoble
Copy link
Member

@zcraber, do you have an example of them using just the "P" anywhere, other than their favicon? It looks to me like they use the full logo pretty much everywhere.

@PeterShaggyNoble PeterShaggyNoble added the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Nov 22, 2023
@zcraber
Copy link
Contributor Author

zcraber commented Nov 23, 2023

do you have an example of them using just the "P" anywhere, other than their favicon?

They have used it in their X profile. @PeterShaggyNoble

Copy link
Member

@adamrusted adamrusted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I agree with @PeterShaggyNoble - they use the full wordmark on every other social platform.
Could you re-work this please @zcraber?

@zcraber
Copy link
Contributor Author

zcraber commented Nov 26, 2023

@adamrusted Done!

@PeterShaggyNoble PeterShaggyNoble removed the awaiting reply Issues or pull requests awaiting reply from an individual before it may be addressed label Dec 7, 2023
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks perfect to me now, thanks, @zcraber 👍🏻 But, before we merge this though, would you be up to trying to clean out some of the excess points in the SVG?

@zcraber
Copy link
Contributor Author

zcraber commented Dec 7, 2023

excess points in the SVG

I checked it. Removing them is causing slight differences as those points were present in the original as well. Would this be an issue? The red colour is the original. Looks like they deliberately added these 'imperfections'. 🤔

image

@PeterShaggyNoble
Copy link
Member

PeterShaggyNoble commented Dec 7, 2023

Oh, wow, it's only now I zoom in fully on the original that I see just how bad it is! 😮 It actually looks like it's the result of running a raster image through a converter. We do try to walk a line between maintaining the integrity of the original icon while removing as many excess points as we can and fixing any minor imperfections that are obviously unintentional.

In this case, though, as the original is so bad, we can't tell exactly what it's supposed to look like. And my own attempts to delete excess points or fix imperfections meet with the same results as yours, introducing some pretty glaring differences.

So, seeing as it currently lines up perfectly with the original, I say we run with this as-is for now in the interests of getting this PR merged, and we can try to take another pass at it in more detail in the future.

@PeterShaggyNoble PeterShaggyNoble merged commit 5e9f965 into simple-icons:develop Dec 7, 2023
3 checks passed
@zcraber zcraber deleted the picxy branch December 7, 2023 20:14
mondeja added a commit that referenced this pull request Dec 10, 2023
# New Icons

- Bakaláři (#10031)
- Bricks (#10022)
- DeepL (#9464)
- Dunzo (#10028)
- Educative (#10036)
- Google Cloud Storage (#9467)
- GrapheneOS (#9281)
- Graphite (#10027)
- Great Learning (#10035)
- Hepsiemlak (#9705)
- Moodle (#10030)
- NETGEAR (#8250)
- Niantic (#9988)
- oclif (#9965)
- Packt (#10038)
- Piapro (#9737)
- Picxy (#9719)
- Resend (#9448)
- Skaffold (#10004)
- Softpedia (#10032)
- Tinkercad (#10033)
- Viblo (#10003)
- Xendit (#9981)

# Updated Icons

- Dassault Systèmes (#8471)
- F-Droid (#10010)
- F-Secure (#10010)
- Flattr (#10010)
- Guangzhou Metro (#10010)
- Lemmy (#10010)
- Lenovo (#10010)
- Monero (#10010)
- MoneyGram (#10010)
- PeerTube (#10010)
- Pegasus Airlines (#10010)
- Pleroma (#10010)
- Reddit (#9964)
- Safari (#9958)
- Write.as (#9884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants