Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oclif #9965

Merged
Merged

Conversation

PratyushJayachandran
Copy link
Member

oclif

Issue: closes #7353

GitHub Stars: 8.6K. See https://github.com/oclif/oclif/

Checklist

  • I updated the JSON data in _data/simple-icons.json
  • I optimized the icon with SVGO or SVGOMG
  • The SVG viewbox is 0 0 24 24

Description

SVG: Taken from GitHub repo https://github.com/oclif/oclif.github.io/blob/2356a96dbaf0d3791ec2ddce3b08ccd78408e0a0/website/static/img/oclif.svg
Color: #000000 Taken from logo

@github-actions github-actions bot added the new icon Issues or pull requests for adding a new icon label Nov 30, 2023
Copy link
Member

@PeterShaggyNoble PeterShaggyNoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG looks good to me, @PratyushJayachandran 👍🏻 There's a hairline difference in the bottom of the "o" but it's insignificant enough that I think we can get away with it. There are however a number of excess points in the original that we may be able to clean up; could you have a look at that?

Also, it looks like they consistently refer to themselves in lowercase everywhere.

_data/simple-icons.json Outdated Show resolved Hide resolved
icons/oclif.svg Outdated Show resolved Hide resolved
Co-authored-by: Peter Noble <15157491+PeterShaggyNoble@users.noreply.github.com>
@PeterShaggyNoble PeterShaggyNoble merged commit de0470f into simple-icons:develop Dec 5, 2023
3 checks passed
@PratyushJayachandran PratyushJayachandran deleted the Add-Oclif branch December 5, 2023 17:40
mondeja added a commit that referenced this pull request Dec 10, 2023
# New Icons

- Bakal&#225;&#345;i (#10031)
- Bricks (#10022)
- DeepL (#9464)
- Dunzo (#10028)
- Educative (#10036)
- Google Cloud Storage (#9467)
- GrapheneOS (#9281)
- Graphite (#10027)
- Great Learning (#10035)
- Hepsiemlak (#9705)
- Moodle (#10030)
- NETGEAR (#8250)
- Niantic (#9988)
- oclif (#9965)
- Packt (#10038)
- Piapro (#9737)
- Picxy (#9719)
- Resend (#9448)
- Skaffold (#10004)
- Softpedia (#10032)
- Tinkercad (#10033)
- Viblo (#10003)
- Xendit (#9981)

# Updated Icons

- Dassault Systèmes (#8471)
- F-Droid (#10010)
- F-Secure (#10010)
- Flattr (#10010)
- Guangzhou Metro (#10010)
- Lemmy (#10010)
- Lenovo (#10010)
- Monero (#10010)
- MoneyGram (#10010)
- PeerTube (#10010)
- Pegasus Airlines (#10010)
- Pleroma (#10010)
- Reddit (#9964)
- Safari (#9958)
- Write.as (#9884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new icon Issues or pull requests for adding a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oclif
3 participants