Skip to content
This repository has been archived by the owner on Mar 7, 2021. It is now read-only.

Cache is useless #375

Closed
Vanuan opened this issue May 29, 2017 · 0 comments · Fixed by #470
Closed

Cache is useless #375

Vanuan opened this issue May 29, 2017 · 0 comments · Fixed by #470

Comments

@Vanuan
Copy link

Vanuan commented May 29, 2017 •
edited

What happened?

Cache isn't used. I.e. crawler doesn't send If-None-Match or If-Modified-Since headers
https://github.com/cgiffard/node-simplecrawler/blob/master/lib/crawler.js#L524
Thus server never sends 304 and crawler doesn't use cache.

What should have happened?

Crawler should verify whether there's an item in cache, get it's ETag of Modified-Since, and generate corresponding headers so that server is able to send 304.
@deton deton mentioned this issue Jun 10, 2019
Merged
kbychkov added a commit that referenced this issue Jun 13, 2019
@kbychkov
Merge pull request #470 from deton/if-none-match
40ad2d3 
fix: send headers If-None-Match and If-Modified-Since, closes #375
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cache: send headers If-None-Match and If-Modified-Since deton/simplecrawler
1 participant
@Vanuan