This repository has been archived by the owner on Mar 7, 2021. It is now read-only.
cache: send headers If-None-Match and If-Modified-Since #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @deton! Thank you for the PR. It's the issue I've found and would like to resolve too. It should definitely be merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes
This PR adds If-None-Match or If-Modified-Since header to fetch request
when fetching url is in cache and ETag or Last-Modified value is cached.
This PR also updates queue
on received 304 not-modified response from server.
Otherwise, crawler does not emit "complete" event.
This PR resolves #375.