Various reports fixes #1240
Merged
Various reports fixes #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to make the latest version of standard happy See rubocop/ruby-style-guide#809 and rubocop/rubocop#8376 for context
rsanheim
commented
Aug 24, 2020
| @@ -206,7 +206,7 @@ function createGraphOptions(isStacked, stepSize, suggestedMax, tickCallbackFunct | |||
| padding: { | |||
| left: 0, | |||
| right: 0, | |||
| top: 48, | |||
| top: 20, | |||
There was a problem hiding this comment.
@claudiovallejo here is the padding tweak
| standard (0.4.2) | ||
| rubocop (~> 0.83.0) | ||
| rubocop-performance (~> 1.5.2) | ||
| standard (0.5.1) |
There was a problem hiding this comment.
This is required to get our local version of standard to match what the GH action pulls down.
Just incase the date formatting change happens to mess w/ our cache keys
timcheadle
approved these changes
Aug 24, 2020
claudiovallejo
approved these changes
Aug 24, 2020
danySam
added a commit
that referenced
this pull request
Aug 25, 2020
…le-server into permissions-ui * 'permissions-ui' of https://github.com/simpledotorg/simple-server: Remove unused packages Introduce a UserAccess model (#1242) Various reports fixes (#1240)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story card:
Details
Jun-2020instead ofJun 2020