Introduce a UserAccess model #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitallis
commented
Aug 25, 2020
| @@ -0,0 +1,82 @@ | |||
| class UserAccess < Struct.new(:user) | |||
| class NotAuthorizedError < StandardError; end | |||
There was a problem hiding this comment.
This will come in handy later.
kitallis
commented
Aug 25, 2020
|
|
||
| def resources_for(resource_model, action) | ||
| return resource_model.all if user.power_user? | ||
| return resource_model.none unless ACTION_TO_LEVEL.fetch(action).include?(user.access_level.to_sym) |
There was a problem hiding this comment.
This clause has been moved up, it used to be like this before. It makes more sense this way since we're just pulling accesses off a concrete User.
harimohanraj89
approved these changes
Aug 25, 2020
danySam
added a commit
that referenced
this pull request
Aug 25, 2020
…le-server into permissions-ui * 'permissions-ui' of https://github.com/simpledotorg/simple-server: Remove unused packages Introduce a UserAccess model (#1242) Various reports fixes (#1240)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story card: https://app.clubhouse.io/simpledotorg/story/128/support-for-adding-and-removing-permissions-to-an-access-level
Because
The User class is lifting a lot of access-related weight, move it out to a more dedicated place.
I first pulled it out into a concern, but it didn't deserve one.
Then I pulled it out into a module/mixin, but mixins are a very poor abstraction that don't mean anything, esp not a great place to put concrete domain logic.
So I eventually pulled up everything from
UserandAccessup into a concrete class that defines theAccessbehavior betweenUserandAccessand just use the Delegator pattern to forward methods fromUsertoUserAccessfor convenience.This also makes the behavior easier to test and doesn't spill over the specs in 2 places.
This addresses
UserAccessUsertoUserAccessAccessandUserpermissions-related specs toUserAccess