Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the slow query explain threshold for New Relic to 0.25 #1284

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

rsanheim
Copy link
Contributor

@rsanheim rsanheim commented Sep 2, 2020

The default is 0.5. Half a second is already a pretty slow query,
especially in the context of a web request. Lets collect some more data
for a while and see what comes up.

/cc #1255

The default is 0.5. Half a second is already a pretty slow query,
especially in the context of a web request. Lets collect some more data
for a while and see what comes up.
@rsanheim rsanheim requested a review from a team September 2, 2020 17:59
@harimohanraj89 harimohanraj89 temporarily deployed to simple-review-pr-1284 September 2, 2020 18:02 Inactive
@rsanheim rsanheim temporarily deployed to simple-review-pr-1284 September 2, 2020 18:04 Inactive
@rsanheim rsanheim merged commit 5a7e025 into master Sep 2, 2020
@rsanheim rsanheim deleted the lower-slow-query-threshold branch September 2, 2020 18:28
harimohanraj89 pushed a commit that referenced this pull request Sep 3, 2020
…1285)

The second git tag here will always fail, because we have already
created the tag as an annotated tag. This causes the script to bail out with an error:

```
[~/src/simpledotorg/simple-server (master)]> bin/release
CHANGELOG
---------
• Lower the explain threshold for New Relic to 0.25 (#1284)
• Add index to rx drugs (#1283)
• Allow Admins to Edit accesses (#1252)
• Migrate the Admin::UsersController and its actions (#1280)
• Index "twilio_sms_delivery_details.session_id" (#1277)
• Inline-ify the clashing function (#1279)
• More efficient strategy for inviting new admins (#1263)
• More efficient tree for displaying access resources (#1262)
• Permissions: flesh out roles and actions (#1208)
Creating release release-2020-09-02-1. Continue? (y/N):
y
fatal: tag 'release-2020-09-02-1' already exists
```

I'm also adding the #releases channel to the final help message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants