More efficient strategy for inviting new admins #1263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by click listener not aware of change when triggered by child
This is done in 2 ways: - memoize critical accessible_methods - lookup the tree using a hash instead of multiple can? methods
- bulk import - check from memory instead of DB
kitallis
changed the title
kitallis
added
the
simple-permissions
8 tasks
vkrmis
approved these changes
Sep 2, 2020
harimohanraj89
pushed a commit
that referenced
this pull request
Sep 3, 2020
…1285) The second git tag here will always fail, because we have already created the tag as an annotated tag. This causes the script to bail out with an error: ``` [~/src/simpledotorg/simple-server (master)]> bin/release CHANGELOG --------- • Lower the explain threshold for New Relic to 0.25 (#1284) • Add index to rx drugs (#1283) • Allow Admins to Edit accesses (#1252) • Migrate the Admin::UsersController and its actions (#1280) • Index "twilio_sms_delivery_details.session_id" (#1277) • Inline-ify the clashing function (#1279) • More efficient strategy for inviting new admins (#1263) • More efficient tree for displaying access resources (#1262) • Permissions: flesh out roles and actions (#1208) Creating release release-2020-09-02-1. Continue? (y/N): y fatal: tag 'release-2020-09-02-1' already exists ``` I'm also adding the #releases channel to the final help message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story card: https://app.clubhouse.io/simpledotorg/story/1108/make-rendering-the-access-tree-and-granting-access-more-efficient
Because
Granting access was horrendously slow (esp for power users) because we were constantly firing a large volume of
UserAccessqueries (regardless of them being cached, see screenshot below).This addresses
Make it more efficient by only querying once and traversing the tree in memory.