Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow VisualizeObjectGraph to generate fully qualified type names #685

Closed
dotnetjunkie opened this issue Apr 18, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@dotnetjunkie
Copy link
Collaborator

commented Apr 18, 2019

Simple Injector's Options.UseFullyQualifiedTypeNames allows Simple Injector to report fully qualified type names (type name + namespace). When visualizing object graphs using InstanceProducer.VisualizeObjectGraph, however, there is no way to influence the generated type names. It will always generate 'friendly class names' instead.

It would be good if VisualizeObjectGraph would be able to override this default, for instance by letting the user do the following:

producer.VisualizeObjectGraph(new VisualizationOptions
{
    UseFullyQualifiedTypeNames = true // Nullable<bool>
});

@dotnetjunkie dotnetjunkie added this to the v4.6 milestone Apr 18, 2019

@dotnetjunkie

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 18, 2019

Feature-685 branch created.

@kwlin

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

Working on it!

@kwlin

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Pull request accepted. See #686

Thanks @dotnetjunkie for the fast acceptance!

@dotnetjunkie dotnetjunkie changed the title Allow VisualizeObjectGraph to generate fully qualified type names when Options.UseFullyQualifiedTypeNames is set Allow VisualizeObjectGraph to generate fully qualified type names May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.