Fix a crash wish unencodable encoding in the encoder. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
force-pushed
the
unencodable-encoder-encoding
branch
3 times, most recently
from
1ecbbeb
to
05cf793
Compare
JSONEncoder.encode() crashed in Python 3 when encoded bytes keys if the encoding was not encodable to utf-8 (contained surrogates).
serhiy-storchaka
force-pushed
the
unencodable-encoder-encoding
branch
from
05cf793
to
9cef9f5
Compare
etrepum
approved these changes
Jun 8, 2017
This was referenced Jun 18, 2017
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jun 26, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jun 27, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jun 27, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jun 28, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jun 28, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jun 29, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jun 30, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jul 4, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jul 4, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jul 5, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jul 5, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jul 6, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jul 6, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
clrpackages
pushed a commit
to clearlinux-pkgs/simplejson
that referenced
this pull request
Jul 15, 2017
…on 3.11.0 Version 3.11.0 released 2017-06-18 * docstring fix in JSONEncoder simplejson/simplejson#172 * Call PyObject_IsTrue() only once for the strict argument of scanner simplejson/simplejson#170 * Fix a crash with unencodable encoding in the encoder simplejson/simplejson#171 * Remove unused imports simplejson/simplejson#162 * Remove remnants of Python 2.4 support simplejson/simplejson#168 * Fix argument checking errors in _speedups.c simplejson/simplejson#169 * Remove the `__init__` methods in extension classes (NEWS truncated at 15 lines)
This was referenced Nov 5, 2017
This was referenced Nov 24, 2017
This was referenced Dec 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSONEncoder.encode()crashed in Python 3 (in recent versions) when encoded bytes keys if the encoding was not encodable to utf-8 (contained surrogates).