Features/landing promo #27
Conversation
There was a problem hiding this comment.
First of all, great PR!
I see four more things in this PR that should be fixed:
-
We should ensure this change is backwards compatible. That's done by checking all specs are green without having to change them but CircleCI is red.
-
There are no specs testing the new skeleton and CSS options. Tests we should include (at least):
- The block is detected as a lazy or normal block.
- The same block in different templates can be detected as a lazy or normal block.
- When a block is lazy it prints the skeleton.
- The CSS files and mediaqueries are correctly returned when asked.
-
There's no documentation on the README. It changes a lot of configuration and it should be explained in the README. In the README should be included that the "lazy mechanism" of how to load a lazy block is up to the app, no this gem. This option is only included so the app can easily include it without having to rewrite all the helpers.
-
CSS files can be included in the asset pipeline by reading the configuration. We should include an assets initializer to include all the detected CSS files in the configuration to the asset pipeline. This way, the programmer doesn't have to include it manually (and forget)
This should also fix the travis suite as the generator spec was dailing because od the missing default skeleton
We fix the case were there's no valid mediaquery for the CSS file
These specs have arisen one issue: There's no lazy blocks option in the general section of a template.
…s-blocks into features/landing-promo
Until now, lazy blocks were only checked with zone configurations, not with the template global configuration
…on key for the block
Carga Lazy de bloques.