if($feed->get_link()) echo '<a href="' . $feed->get_link() . '">';
if ($feed->get_link()) echo '</a>';
What's wrong here is that you're calling a method three times (!) in order to achieve a result that can be determined by calling it once.
This whole approach is just strange to me, since the alternative is so much more efficient and simple... for example in this case:
$link = $feed->get_link();
$title = $feed->get_title();
$title = "<a href='$link' title='$title'>$title</a>";
Not only is the code more efficient - it's far easier to visually parse and edit and the html being produced can be more beautifully/strictly formatted without headache.
Just my 2 cents...
I agree. @hajikelist why don't you fork, fix & commit the updates?
ha ha. I would if my schedule were a little more relaxed. I feel compelled to address it across the board, perhaps I'll see if can squeeze it in...
Unfortunately, I also have very little time, so if it ain't broke...
Issue #191 Some remarks about poor programming practices...
Issue #191 Style fixes...