-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some remarks about poor programming practices... #191
Labels
Milestone
Comments
I agree. @hajikelist why don't you fork, fix & commit the updates? |
ha ha. I would if my schedule were a little more relaxed. I feel compelled to address it across the board, perhaps I'll see if can squeeze it in... |
Unfortunately, I also have very little time, so if it ain't broke... |
ifsnop
added a commit
to ifsnop/simplepie
that referenced
this issue
Jul 20, 2012
ifsnop
added a commit
to ifsnop/simplepie
that referenced
this issue
Jul 20, 2012
ifsnop
added a commit
to ifsnop/simplepie
that referenced
this issue
Jul 20, 2012
ifsnop
added a commit
to ifsnop/simplepie
that referenced
this issue
Jul 20, 2012
ifsnop
added a commit
to ifsnop/simplepie
that referenced
this issue
Jul 20, 2012
ifsnop
added a commit
to ifsnop/simplepie
that referenced
this issue
Aug 27, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What's wrong here is that you're calling a method three times (!) in order to achieve a result that can be determined by calling it once.
This whole approach is just strange to me, since the alternative is so much more efficient and simple... for example in this case:
Not only is the code more efficient - it's far easier to visually parse and edit and the html being produced can be more beautifully/strictly formatted without headache.
Just my 2 cents...
The text was updated successfully, but these errors were encountered: