PHP 8.0: prevent ValueError for invalid encoding #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the encoding against the list of supported encodings before ever calling `mb_convert_encoding()`.
|
FYI: alternatively the order can remain the same, but then the first condition should be wrapped in a try/catch. |
|
hi @jrfnl that's ok I think flipping it the way you have is fine. Thanks for all these changes they look good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the encoding against the list of supported encodings before ever calling
mb_convert_encoding().This prevents a fatal
ValueErroron PHP 8.0 when passing an invalid encoding and maintains the documented behaviour of returningfalseon an invalid encoding.