Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: switch to GH Actions #688

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Aug 10, 2021

Travis is dead, long live Travis!

This commit:

  • Adds a GH Actions workflow for the CI checks which were previously run on Travis.
  • Removes the, now redundant, .travis.yml configuration.
  • Updates the .gitattributes file.

Other typical changes which I would usually make, do not apply to this repo.

  • Updates the "Build Status" badge in the Readme to use the results from the GH Actions runs.

Significant differences between this script and the original Travis script:

  • I've not perpetuated the branch exception for the one-dot-two branch as that branch seems to be abandoned anyhow.
  • Added testing against PHP 8.0 and PHP 8.1, with the test run against both being allowed to fail (for now).
    On PHP 8.0, the tests do actually run, but show a failure.
    On PHP 8.1, the tests do not run due to the PHPUnit version being used not being compatible with PHP 8.1 and as that version of PHPUnit is no longer supported, it won't be made compatible with PHP 8.1 anymore either.

Related #663

Travis is dead, long live Travis!

This commit:
* Adds a GH Actions workflow for the CI checks which were previously run on Travis.
* Removes the, now redundant, `.travis.yml` configuration.
* Updates the `.gitattributes` file.

Other typical changes which I would usually make, do not apply to this repo.
* ~~Updates the "Build Status" badge in the Readme to use the results from the GH Actions runs.~~

Significant differences between this script and the original Travis script:
* I've not perpetuated the branch exception for the `one-dot-two` branch as that branch seems to be abandoned anyhow.
* Added testing against PHP 8.0 and PHP 8.1, with the test run against both being allowed to fail (for now).
    On PHP 8.0, the tests do actually run, but show a failure.
    On PHP 8.1, the tests do not run due to the PHPUnit version being used not being compatible with PHP 8.1 and as that version of PHPUnit is no longer supported, it won't be made compatible with PHP 8.1 anymore either.

Related 663
@jrfnl
Copy link
Contributor Author

jrfnl commented Aug 11, 2021

FYI: to verify the build, you can look at the action run in my fork: https://github.com/jrfnl/simplepie/runs/3294162182?check_suite_focus=true

@mblaney mblaney merged commit 1ab16b1 into simplepie:master Aug 14, 2021
@jrfnl jrfnl deleted the feature/switch-to-ghactions branch August 14, 2021 02:33
@mblaney
Copy link
Member

mblaney commented Aug 14, 2021

thanks @jrfnl, so you're allowing it to fail with the aim of fixing the failures next, is that correct?

@jrfnl
Copy link
Contributor Author

jrfnl commented Aug 14, 2021

@mblaney Correct ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants