PHP 8.1: fix "passing null to non-nullable" deprecation notice #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mblaney
reviewed
Aug 14, 2021
As of PHP 8.1, passing `null` to non-nullable arguments of PHP native functions is deprecated. Ref: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg The `SimplePie_Enclosure::get_extension()` returns the file extension as a string or `null`. In the `SimplePie_Enclosure::get_real_type()` method, the return value of a call to the `get_extension()` method was directly passed on to the PHP native `strtolower()` function, leading to the PHP 8.1 `strtolower(): Passing null to parameter simplepie#1 ($string) of type string is deprecated` deprecation notice. This small change fixes this issue without BC break. This is covered by 36 of the existing tests in the `OldTest` class.
jrfnl
force-pushed
the
feature/php-8.1-fix-passing-null-to-non-nullable
branch
from
08ee8ce
to
8b0e86f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 8.1, passing
nullto non-nullable arguments of PHP native functions is deprecated.Ref: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg
The
SimplePie_Enclosure::get_extension()returns the file extension as a string ornull.In the
SimplePie_Enclosure::get_real_type()method, the return value of a call to theget_extension()method was directly passed on to the PHP nativestrtolower()function, leading to the PHP 8.1strtolower(): Passing null to parameter #1 ($string) of type string is deprecateddeprecation notice.This small change fixes this issue without BC break.
This is covered by 36 of the existing tests in the
OldTestclass.