Tests: use strict assertions #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPUnit contains a variety of assertions and the ones available have been extended hugely over the years. To have the most reliable tests, the most specific assertion should be used. Most notably, this changes calls to `assertEquals()` to `assertSame()`, where `assertEquals()` does a loose type comparison `==` and `assertSame()` does a strict type `===` comparison. The only real exception to this is when comparing two objects, as in that case, the objectID will not be the same, so those should still use `assertEquals()` - or the PHPUnit 9.4.0 `assertObjectEquals()` method for comparing value objects using a callback method in the ValueObject class.
The custom `assertEqualsBin2Hex()` assertion was using `assertEquals()` as well. When changing this to `assertSame()`, it makes sense to also change the custom assertion method name to `assertSameBin2Hex()` and adjust all calls to the method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests: use strict assertions
PHPUnit contains a variety of assertions and the ones available have been extended hugely over the years.
To have the most reliable tests, the most specific assertion should be used.
Most notably, this changes calls to
assertEquals()toassertSame(), whereassertEquals()does a loose type comparison==andassertSame()does a strict type===comparison.The only real exception to this is when comparing two objects, as in that case, the objectID will not be the same, so those should still use
assertEquals()- or the PHPUnit 9.4.0assertObjectEquals()method for comparing value objects using a callback method in the ValueObject class.Tests: use strict assertions in custom assertion
The custom
assertEqualsBin2Hex()assertion was usingassertEquals()as well.When changing this to
assertSame(), it makes sense to also change the custom assertion method name toassertSameBin2Hex()and adjust all calls to the method.