Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse\Date: Clean up regex structure #765

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Nov 13, 2022

Looks like there are no tests 馃し鈥嶁檧

@jtojnar jtojnar marked this pull request as ready for review November 14, 2022 13:57
Copy link
Contributor

@Art4 Art4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the well formated $pcre with named subpatterns very much. 馃槂 And special 馃憤 for adding the tests.

src/Parse/Date.php Outdated Show resolved Hide resolved
@mblaney mblaney merged commit 72a0b8c into simplepie:master Dec 2, 2022
Art4 added a commit to Art4/simplepie that referenced this pull request Dec 2, 2022
@jtojnar jtojnar deleted the regex-refactor branch December 2, 2022 14:05
mblaney pushed a commit that referenced this pull request Jan 20, 2023
* bump version to 1.8.0

* Update CHANGELOG.md

* Fix version tags in deprecated messages

* fix version in old deprecation messages

* Fix typo

see comment from @jtojnar in #752

* Add comment for DataCache interface

see comment from @jtojnar in #752

* Update CHANGELOG.md for #760, #764 and #765

* Update CHANGELOG.md for #762, #767 and #763

* Update CHANGELOG.md for #768 and #770

* Update release date

* Update CHANGELOG.md for #769 and #771

* Update CHANGELOG.md for #766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants