Fix case of multiple RSS2.0 enclosures #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line was introduced in simplepie@8a5f601#diff-a710c236cc7775672edbe5840d8fb96b0e91b0d56eff709f6eace2da47c1fe43R349-R359 Seems to be a similar error than simplepie@efb1d8e Having an `urldecode` returns some potentially invalid URLs, while SimplePie does not do that for other returned URLs Downstream PR FreshRSS/FreshRSS#4944 P.S. There are a few other bugs related to enclosure links, and I will try to address some of them in distinct PRs.
SimplePie only returned the first enclosure when using the RSS 2.0 syntax for enclosures, instead of returning them all. Please merge simplepie#768 first. Downtream PR: FreshRSS/FreshRSS#4944
Art4
reviewed
Dec 31, 2022
Co-authored-by: Artur Weigandt <Art4@users.noreply.github.com>
jtojnar
reviewed
Jan 1, 2023
|
It is not clear from the RSS spec if multiple enclosures are valid but it makes sense to me to err on the side of accepting it since the ambiguity allows feed producers to do this. https://www.rssboard.org/rss-validator/docs/warning/DuplicateEnclosure.html |
Co-authored-by: Jan Tojnar <jtojnar@gmail.com>
Co-authored-by: Jan Tojnar <jtojnar@gmail.com>
|
For the record, when using the |
Art4
approved these changes
Jan 12, 2023
Art4
added a commit
to Art4/simplepie
that referenced
this pull request
Jan 20, 2023
mblaney
pushed a commit
that referenced
this pull request
Jan 20, 2023
* bump version to 1.8.0 * Update CHANGELOG.md * Fix version tags in deprecated messages * fix version in old deprecation messages * Fix typo see comment from @jtojnar in #752 * Add comment for DataCache interface see comment from @jtojnar in #752 * Update CHANGELOG.md for #760, #764 and #765 * Update CHANGELOG.md for #762, #767 and #763 * Update CHANGELOG.md for #768 and #770 * Update release date * Update CHANGELOG.md for #769 and #771 * Update CHANGELOG.md for #766
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimplePie only returned the first enclosure when using the RSS 2.0 syntax for enclosures, instead of returning them all.
Please merge #768 first.
Downtream PR: FreshRSS/FreshRSS#4944