-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt in to accept empty subject confirmation data. #840
Open
m0ark
wants to merge
8
commits into
simplesamlphp:master
Choose a base branch
from
m0ark:opt-in-empty-scd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viour is unchanged to ensure SAML sso profiles are handled properly.
…viour is unchanged to ensure SAML sso profiles are handled properly.
So this is a variant of #825. On the code itself my comment would be that I do want to avoid negatively worded parameters, so not |
Codecov Report
@@ Coverage Diff @@
## master #840 +/- ##
============================================
- Coverage 38.36% 38.35% -0.02%
- Complexity 3385 3386 +1
============================================
Files 128 128
Lines 9633 9636 +3
============================================
Hits 3696 3696
- Misses 5937 5940 +3 |
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
August 17, 2020 20:43
1c686ab
to
eb20457
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
July 2, 2021 14:12
08ebb9c
to
64fca25
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
September 26, 2021 13:03
7a53fc8
to
d73ae47
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
January 9, 2022 11:00
e5c0e21
to
d5616df
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
November 23, 2022 18:24
2e6ab04
to
32f9acc
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
January 5, 2023 16:01
c743c9a
to
fc71570
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
June 12, 2023 14:28
c7c8357
to
fdbe001
Compare
tvdijen
force-pushed
the
master
branch
8 times, most recently
from
July 19, 2023 12:37
3b5f5ba
to
96357ee
Compare
tvdijen
force-pushed
the
master
branch
5 times, most recently
from
August 2, 2023 11:58
7587851
to
d523b31
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
September 5, 2023 08:09
8c90121
to
d534e3b
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
October 17, 2023 21:17
bc1c5c8
to
d0a5974
Compare
tvdijen
force-pushed
the
master
branch
3 times, most recently
from
December 1, 2023 14:34
ccb9b02
to
120a100
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
May 4, 2024 23:45
6004a77
to
58bf8db
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
May 27, 2024 12:27
5c9fb2c
to
0970efc
Compare
tvdijen
force-pushed
the
master
branch
2 times, most recently
from
June 19, 2024 17:03
c27831c
to
71e49f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the behaviour is unchanged to ensure SAML sso profiles are handled properly.
Enables utilization for processing other SAML messages, e.g. attribute queries, where SubjectConfirmationData is optional.