-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(keg-core): Update dependencies #184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Got sidebar working * Add helper hooks * Need to fix sidbar size * Need to fix toggle
* Finish basic example * Cleaned up styles * Also cleaned up section list Todo * Add JSDocs * Add way to disable toggle component * Show example of custom toggle component
* Moved list components into sub folders * Copied simpleList from keg-herkin * Update some imports TODO - Updated all imports of simpleList files
Storybook restart not working?
* Added exmaples * Need to add JSDoc and cleanup
* Added and cleaned up examples * Added defautl props * Need to add JSDocs
* Rollup now replace native deps with web deps * Cleaned up package.json
* Throws an error when config file exists, but can't be loaded * excludes package.json file
* Update to use same build script generation as retheme
* Update build index generation scripts
mpcarolin
reviewed
Aug 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good through Test 2. Test 3 is missing some details, though. Also one of the checks aren't passing.
mpcarolin
approved these changes
Aug 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: ZEN-614
Goal
Updates
repos/keg-core/core/base/assets/**
tap-resolver
, but the build was throwing an error when they didn't existrepos/keg-core/core/configs/eslintrc.config.js
repos/keg-core/package.json
dependencies
types to the latest versions where neededresolutions
to use the latest versionsweb:build
so it matches most tap build scriptsTests
Setup
keg dpg run --package keg-core:ZEN-614-update-core --env prod
Test 1
Test 2
keg core att
cat /keg/keg-core/node_modules/@keg-hub/keg-components/package.json | grep @babel/core
cat /keg/keg-core/node_modules/@keg-hub/re-theme/package.json | grep @babel/core
@babel/core
version from the package.json of the repoyarn build
in bothkeg-components
andre-theme
foldersTest 3
keg evf pack run evf:zen-614-tap-test
*Navigate to [the events-force app] (http://evf-zen-614-tap-test.local.keghub.io/) in your browser
keg evf pack run --package evf:zen-614-tap-test --env prod