Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(keg-core): Update dependencies #184

Merged
merged 38 commits into from
Aug 18, 2021
Merged

Conversation

lancetipton
Copy link
Contributor

@lancetipton lancetipton commented Aug 12, 2021

Ticket: ZEN-614

Goal

  • Update the dependencies of keg-core
  • Fix any issues related to the dependency updates

Updates

  • repos/keg-core/core/base/assets/**
    • Added a couple init files that are ignored by default
    • These files get overwritten by tap-resolver, but the build was throwing an error when they didn't exist
  • repos/keg-core/core/configs/eslintrc.config.js
    • eslint config fixes due to dep updates
    • Fixed issue causing ESLint to error
  • repos/keg-core/package.json
    • Updated all the dependencies types to the latest versions where needed
    • Updated/Added resolutions to use the latest versions
    • Added missing web:build so it matches most tap build scripts

Tests

Setup

  • Run this command keg dpg run --package keg-core:ZEN-614-update-core --env prod

Test 1

  • Navigate to the keg-core app in your browser
    • Ensure the app runs as expected
  • Use the select box in the top right to switch to the plugins page
    • Interact with the plugins page and ensure it works as expected
  • You should not see any errors in the inspector console

Test 2

  • Next validate that the keg-components and re-theme code is the correct code
  • Connect to the running docker container keg core att
  • Then run following command
    • cat /keg/keg-core/node_modules/@keg-hub/keg-components/package.json | grep @babel/core
    • cat /keg/keg-core/node_modules/@keg-hub/re-theme/package.json | grep @babel/core
  • Those commands should print out the @babel/core version from the package.json of the repo
    • Ensure the version is 7.14.8 for both
    • Looks like this
    • Side note - If you really want to, you can run yarn build in both keg-components and re-theme folders
      • This ensure the latest code is being used. But FYI, I already did that
  • Compare that with the versions currently on develop

Test 3

  • Run keg-core inside a tap by running keg evf pack run evf:zen-614-tap-test
    • It should pull and run the image
      *Navigate to [the events-force app] (http://evf-zen-614-tap-test.local.keghub.io/) in your browser
    • Ensure the tap works as expected
    • Ensure there are no issues related to running the tap, and loading the tap files
  • Exit running container, then run the command => keg evf pack run --package evf:zen-614-tap-test --env prod
    • This should run the same container in production
    • Ensure the tap works as expected
    • Ensure there are no issues related to running the tap, and loading the tap files
  • Notes
    • If you do find a bug, make sure it's related to the keg-core updates, and not the tap
    • You can use the events-force demo page to compare

  * Got sidebar working
  * Add helper hooks
  * Need to fix sidbar size
  * Need to fix toggle
  * Finish basic example
  * Cleaned up styles
  * Also cleaned up section list
Todo
  * Add JSDocs
  * Add way to disable toggle component
  * Show example of custom toggle component
  * Moved list components into sub folders
  * Copied simpleList from keg-herkin
  * Update some imports
  TODO - Updated all imports of simpleList files
Storybook restart not working?
  * Added exmaples
  * Need to add JSDoc and cleanup
  * Added and cleaned up examples
  * Added defautl props
  * Need to add JSDocs
  * Rollup now replace native deps with web deps
  * Cleaned up package.json
  * Throws an error when config file exists, but  can't be loaded
  * excludes package.json file
  * Update to use same build script generation as retheme
  * Update build index generation scripts
Copy link
Contributor

@mpcarolin mpcarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good through Test 2. Test 3 is missing some details, though. Also one of the checks aren't passing.

Copy link
Contributor

@mpcarolin mpcarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lancetipton lancetipton merged commit bb8ce38 into develop Aug 18, 2021
@lancetipton lancetipton deleted the ZEN-614-update-core branch August 18, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants