-
Notifications
You must be signed in to change notification settings - Fork 18
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the plugin to 1.0.3 #60
Comments
For now I have put 1.0.2 (built from KoanCode/grails-gwt tag 1.0.2) in an org level bintray: repositories { |
@oniseijin, hi! Please, try this version: I fixed a lot of bugs and improved some functional. I will try to contact with original author and ask permission to release 2.0 version. |
Please, try this version: I fixed a lot of bugs and improved some functional. I will try to contact with original author and ask permission to release 2.0 version. —Reply to this email directly or view it on GitHub. |
What about I get permission to release this plugin in Grails Portal? |
@daviddawson : Thanks for the reply, yes, all that is needed is a maintenance release looking at my version, and yours, all is needed from your end is to authorize, or publish 1. Take current master I can confirm it all with GWT 2.6 and 2.7. @donbeave : let me take a look, for now, I think getting a 1.1 from the main repo would solve the core GWT version problems: I see that you got grails 2.4+ working, which would be great, and justify a 2.0 after the 1.1 is done. |
@donbeave : confirmed, got 2.0-SNAPSHOT working (although, moving compiled from gwt to js/gwt might break things for people, although a simple Config.groovy abstraction is all that is needed, or a search replace eg> src='${resource(dir:"${grailsApplication.config.gwt.js.dir}/explorer"). So, I'm all for the 2.0 |
@oniseijin, do you use asset-pipeline or resources plugin? In my version gwt js output dir depend on which plugin installed: gwtOutputPath = getPropertyValue('gwt.output.path', isAssetPipelinePluginInstalled ?
"$basedir/grails-app/assets/javascripts/gwt" : "$basedir/web-app/js/gwt") Or you also can set your path manually by override: gwt.output.path. |
It goes to #basedir/web-app/js/gwt as commented... just that the default in the 1.x went to $basedir/webapp/gwt. Probably best to keep it as the 1.0 sets it, and others can override. Just my thoughts to get this considered as a 2.0 candidate. And thanks forgot about gwt.output.path, that makes it trivial, but I'll with you on putting it under js/gwt actually :) |
@donbeave @oniseijin I have added you to the contribs group for the repo, which has full access. having one or other of you gents be able to make releases sounds like a good idea. I'm happy to do that in the interim if you'd like to prep, agree and commit the PR requests for the releases you'd like. |
Thanks David, It looks like don has connected his fork into Travis, so it makes sense to go there, although build/publish is easy locally The core missing piece is to have access to publish to the core grails plugin library. I've got an account at grails: looks like all we'd have to do is update the code, publish locally, and fill in a form. I'd like to go ahead with a 1.0.3 version, and then discuss with Don about the 2.0 items. Regards, @donbeave https://github.com/donbeave @oniseijin https://github.com/oniseijin I have added you to the contribs group for the repo, which has full access. having one or other of you gents be able to make releases sounds like a good idea. I'm happy to do that in the interim if you'd like to prep, agree and commit the PR requests for the releases you'd like. — |
ok, if you commit that PR making a 1.0.3, I can do the release to get it out of the door, then all the ones after one of you gents can handle :-) |
Well, the commit log spoiled all the comment fun: changed, tested, tagged, and pushed. Ready to submit to grails repo as 1.0.3. |
@daviddawson Thanks for all your support, if you get this one out, we can get the next one ;) Maybe we can start a 2.0 "issue" |
1.0.3 has been released. Thanks! |
General request to publish a 1.0.3 version that has issue #56 fixed (among others). I got my fork to fully work at KoanCode.
For now I've forked it and trying to get it on jcenter (a 1.0.2 version), from the fork I have (although I'm not if I would be allowed to use the org.grails.plugins namespace, but will see).
Once done, no need for any forks or uploading anywhere else!
The text was updated successfully, but these errors were encountered: