Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the plugin to 1.0.3 #60

Closed
oniseijin opened this issue Mar 26, 2015 · 14 comments
Closed

Upgrade the plugin to 1.0.3 #60

oniseijin opened this issue Mar 26, 2015 · 14 comments

Comments

@oniseijin
Copy link
Contributor

General request to publish a 1.0.3 version that has issue #56 fixed (among others). I got my fork to fully work at KoanCode.

For now I've forked it and trying to get it on jcenter (a 1.0.2 version), from the fork I have (although I'm not if I would be allowed to use the org.grails.plugins namespace, but will see).

Once done, no need for any forks or uploading anywhere else!

@oniseijin
Copy link
Contributor Author

For now I have put 1.0.2 (built from KoanCode/grails-gwt tag 1.0.2) in an org level bintray:

repositories {
maven {
url "http://dl.bintray.com/koancode/maven"
}
}

@donbeave
Copy link
Contributor

@oniseijin, hi!

Please, try this version:
https://github.com/donbeave/grails-gwt

I fixed a lot of bugs and improved some functional.

I will try to contact with original author and ask permission to release 2.0 version.

@daviddawson
Copy link

                                                                                  Hello. I'm happy to help anyone who wants help with maintenance or release new versions. Just let me know what you need.I'm very sorry for not paying more attention to this, it's slipped down my priority list.                                                                                                                                                                                                                                                                                                                                        --David DawsonCEO Simplicity Itself LtdTel +7866011256Skype davidadawsondavid.dawson@simplicityitself.comhttp://www.simplicityitself.com                                                                                                                                                                                                                From: BeaVeSent: Friday, 27 March 2015 08:02To: simplicityitself/grails-gwtReply To: simplicityitself/grails-gwtSubject: Re: [grails-gwt] Upgrade the plugin to 1.0.3 (#60)@oniseijin, hi!

Please, try this version:
https://github.com/donbeave/grails-gwt

I fixed a lot of bugs and improved some functional.

I will try to contact with original author and ask permission to release 2.0 version.

—Reply to this email directly or view it on GitHub.

@donbeave
Copy link
Contributor

What about I get permission to release this plugin in Grails Portal?

@oniseijin
Copy link
Contributor Author

@daviddawson : Thanks for the reply, yes, all that is needed is a maintenance release looking at my version, and yours, all is needed from your end is to authorize, or publish 1. Take current master
2. Update GrailsGwtPlugin.groovy to be version 1.0.3 (or 1.1)
3. Publish plugin

I can confirm it all with GWT 2.6 and 2.7.

@donbeave : let me take a look, for now, I think getting a 1.1 from the main repo would solve the core GWT version problems: I see that you got grails 2.4+ working, which would be great, and justify a 2.0 after the 1.1 is done.

@oniseijin
Copy link
Contributor Author

@donbeave : confirmed, got 2.0-SNAPSHOT working (although, moving compiled from gwt to js/gwt might break things for people, although a simple Config.groovy abstraction is all that is needed, or a search replace eg> src='${resource(dir:"${grailsApplication.config.gwt.js.dir}/explorer"). So, I'm all for the 2.0

@donbeave
Copy link
Contributor

@oniseijin, do you use asset-pipeline or resources plugin?

In my version gwt js output dir depend on which plugin installed:

gwtOutputPath = getPropertyValue('gwt.output.path', isAssetPipelinePluginInstalled ?
        "$basedir/grails-app/assets/javascripts/gwt" : "$basedir/web-app/js/gwt")

Or you also can set your path manually by override: gwt.output.path.

@oniseijin
Copy link
Contributor Author

It goes to #basedir/web-app/js/gwt as commented... just that the default in the 1.x went to $basedir/webapp/gwt. Probably best to keep it as the 1.0 sets it, and others can override. Just my thoughts to get this considered as a 2.0 candidate.

And thanks forgot about gwt.output.path, that makes it trivial, but I'll with you on putting it under js/gwt actually :)

@daviddawson
Copy link

@donbeave @oniseijin I have added you to the contribs group for the repo, which has full access.

having one or other of you gents be able to make releases sounds like a good idea.

I'm happy to do that in the interim if you'd like to prep, agree and commit the PR requests for the releases you'd like.
We've actually got this project building on our internal team city instance. We should probably move that to some public CI infrastructure instead. Any preferences or ideas?

@oniseijin
Copy link
Contributor Author

Thanks David,

It looks like don has connected his fork into Travis, so it makes sense to go there, although build/publish is easy locally

The core missing piece is to have access to publish to the core grails plugin library. I've got an account at grails: looks like all we'd have to do is update the code, publish locally, and fill in a form.

I'd like to go ahead with a 1.0.3 version, and then discuss with Don about the 2.0 items.

Regards,
Ryan
On Mar 28, 2015, at 9:53 PM, David Dawson notifications@github.com wrote:

@donbeave https://github.com/donbeave @oniseijin https://github.com/oniseijin I have added you to the contribs group for the repo, which has full access.

having one or other of you gents be able to make releases sounds like a good idea.

I'm happy to do that in the interim if you'd like to prep, agree and commit the PR requests for the releases you'd like.
We've actually got this project building on our internal team city instance. We should probably move that to some public CI infrastructure instead. Any preferences or ideas?


Reply to this email directly or view it on GitHub #60 (comment).

@daviddawson
Copy link

ok, if you commit that PR making a 1.0.3, I can do the release to get it out of the door, then all the ones after one of you gents can handle :-)

@oniseijin
Copy link
Contributor Author

Well, the commit log spoiled all the comment fun: changed, tested, tagged, and pushed. Ready to submit to grails repo as 1.0.3.

@oniseijin
Copy link
Contributor Author

@daviddawson Thanks for all your support, if you get this one out, we can get the next one ;)
@donbeave , let's chat outside this item: your 2.0-SNAPSHOT does indeed rock (and is super fast!) Just after doing 1.0.3 I switched back... good work.

Maybe we can start a 2.0 "issue"

@daviddawson
Copy link

1.0.3 has been released.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants