Use stdlib toml provider on Python >= 3.11. Switch to tomli otherwise #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjw296
reviewed
Sep 8, 2023
cjw296
reviewed
Sep 9, 2023
|
@cjw296 It turned out to be much cleaner and simpler modifying |
cjw296
reviewed
Sep 12, 2023
configurator/config.py
Outdated
| stream = StringIO(text) | ||
| return cls.from_stream(stream, parser) | ||
| if isinstance(text, bytes): | ||
| text = text.decode(encoding) |
There was a problem hiding this comment.
Are you looking at an older commit? There should be no changes in config.py any longer.
The conversion from bytes to text is there in master currently, since 2019 acc21db
| @@ -33,5 +25,5 @@ def __missing__(self, extension): | |||
| except KeyError: | |||
| raise ParseError('No parser found for {!r}'.format(extension)) | |||
| else: | |||
| module = __import__(module_name) | |||
| module = import_module(module_name) | |||
cjw296
approved these changes
Sep 12, 2023
|
When are you looking for a release? ASAP? |
|
Wherever it’s ready. This is for an app, so I don’t mind to lock my requirements txt directly to the git hash in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to use configurator with a TOML file in Python 3.11, but lose that 3rd-party
tomldependency, since Python 3.11+ hastomllib.The current provider is not compliant with the TOML spec and does not roundtrip:
For Python < 3.11, may I recommend to move to
tomli, which is what stdlibtomllibwas based upon. Many existing projects usetomli(e.g.pip,build,pytest,mypy,black,flit,coverage,setuptools-scm,cibuildwheel). According to PEP 680, the projectuiri/tomlwas rejected because it's not actively maintained, does not support TOML 1.0.0 and has a number of known bugs.Unfortunately the abstractions in configurator made it a little complicated to integrate
tomli/tomllib, because the TOML specification requires the input to be UTF-8.tomliimplements this requirement by forcing the user to use binary mode "b" when reading the file, then does the decoding. I've tried my best to handle TOML files in a correct way, without drastic refactoring.