#138 Add default log check(assert) requirements for LogCapture #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjw296
approved these changes
Oct 9, 2020
cjw296
reviewed
Jun 7, 2024
There was a problem hiding this comment.
So yeah, this is an example of a terrible commit message, and I'm adding this comment mainly to remind myself to not let this kind of crap get to master.
This PR adds a lot of functionality until this bad commit message, including some nasty gotchas around truthiness of Handler objects as used by logging internals.
Comment on lines
+87
to
+97
| def __len__(self): | ||
| return len(self.records) | ||
|
|
||
| def __getitem__(self, index): | ||
| return self._actual_row(self.records[index]) | ||
|
|
||
| def __contains__(self, what): | ||
| for i, item in enumerate(self): | ||
| if what == item: | ||
| self.records[i].checked = True | ||
| return True |
There was a problem hiding this comment.
It's pretty annoying that these were introduced here. This PR has a particularly poor commit message and these three methods actually have some quite significant impact in terms of how this Handler behaves with respect to some logging internals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.