Performance improvement for Mustermann::AST::Translator#escape #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentarg
reviewed
Aug 23, 2024
Comment on lines
+121
to
+127
| def uri_parser | ||
| if defined?(URI::RFC2396_PARSER) | ||
| URI::RFC2396_PARSER | ||
| else | ||
| @uri_parser ||= URI::RFC2396_Parser.new | ||
| end | ||
| end |
There was a problem hiding this comment.
CI require 100% coverage so we need to cover this branching in the specs
There was a problem hiding this comment.
If it is possible in some resonable way? I don't know. If not, can we opt-out from the coverage requirement just for this code?
There was a problem hiding this comment.
Although, I don't know where URI::RFC2396_PARSER comes from :(
There was a problem hiding this comment.
Oh got it. It's in the next version of Ruby.
This was referenced Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #140
see
bench/uri_parser_object.rb.Before:
h2[URI::RFC2396_Parser] - h1[URI::RFC2396_Parser]is 200After:
h2[URI::RFC2396_Parser] - h1[URI::RFC2396_Parser]is 0